Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Methods from Deref<Target={primitive}> section in documentation for types in #![no_std] crates #32553

Closed
mitaa opened this issue Mar 28, 2016 · 6 comments
Labels
C-bug Category: This is a bug. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mitaa
Copy link
Contributor

mitaa commented Mar 28, 2016

The links to as_ptr and chars on the collection crates page of String are broken.

This is because they refer to methods of str but link to the same page (String), relying on the Methods from Deref<Target=str> section which is missing for some reason (seems to apply to the entire collections crate).

@alexcrichton alexcrichton added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 28, 2016
@steveklabnik
Copy link
Member

This is a duplicate of #32129

@ollie27
Copy link
Member

ollie27 commented Mar 22, 2017

This isn't a dupe of #32129. The issue here is the lack of the Methods from Deref<Target=str> section on the collections::string::String page which I believe is because it's a #![no_std] crate. So this needs to be reopened.

@steveklabnik steveklabnik reopened this Mar 22, 2017
@steveklabnik steveklabnik added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label May 18, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 24, 2017
@MaloJaffre
Copy link
Contributor

MaloJaffre commented Dec 28, 2017

Here is a reduced testcase:

#![no_std]
pub struct DeStr;
impl core::ops::Deref for DeStr {
    type Target = str;
    fn deref(&self) -> &str {
        unimplemented!()
    }
}

@ollie27 ollie27 changed the title Broken Link fragments in String documentation Missing Methods from Deref<Target={primitive}> section in documentation for types in #![no_std] crates Jul 18, 2020
@jyn514
Copy link
Member

jyn514 commented Jul 18, 2020

This looks like a duplicate of #73423.

Manishearth added a commit to Manishearth/rust that referenced this issue Jul 19, 2020
More intra-doc links, add explicit exception list to linkchecker

Fixes the broken links behind rust-lang#32553

Progress on rust-lang#32130 and rust-lang#32129 except for a small number of links. Instead of whitelisting entire files, I've changed the code to whitelist specific links in specific files, and added a comment requesting people explain the reasons they add exceptions. I'm not sure if we should close those issues in favor of the already filed intra-doc link issues.
@Nemo157
Copy link
Member

Nemo157 commented Aug 17, 2020

no_std doesn't seem relevant, removing it from the reduced testcase still fails to add a "Mtehods from Deref<Target = str>" section (though it does create a broken link to it in the sidebar).

@jyn514
Copy link
Member

jyn514 commented Apr 8, 2021

This is fixed on master:
image

@jyn514 jyn514 closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

8 participants