Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint that all crates are #[unstable] #31122

Closed
brson opened this issue Jan 22, 2016 · 4 comments
Closed

Add lint that all crates are #[unstable] #31122

brson opened this issue Jan 22, 2016 · 4 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@brson
Copy link
Contributor

brson commented Jan 22, 2016

It's easy to forget to write it when adding new crates, as in #31120, and then release a crate as stable accidentally.

In tidy.py add a whitelist of crates that can be stable; in the loop, if the file name looks like 'src/*/lib.rs' it should have the attribute unless its on the whitelist.
@brson brson added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-testsuite Area: The testsuite used to check the correctness of rustc labels Jan 22, 2016
@brson brson mentioned this issue Jan 22, 2016
Merged
@alexcrichton
Copy link
Member

👍

@brson
Copy link
Contributor Author

brson commented Jan 22, 2016

Since #31120 also was adding a single attribute everywhere, the lint might additionally look for other common crate attributes.

@brson brson added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Jan 22, 2016
@brson
Copy link
Contributor Author

brson commented Jan 22, 2016

I can mentor.

@KiChjang
Copy link
Member

Can I pick this up? I've been meaning to understand the business of lints.

@KiChjang KiChjang mentioned this issue Feb 13, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 15, 2016
@Manishearth
Rollup merge of rust-lang#31627 - KiChjang:unstable-lint, r=alexcrichton
c078e34 
Fixes rust-lang#31122.
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 16, 2016
@Manishearth
Rollup merge of rust-lang#31627 - KiChjang:unstable-lint, r=alexcrichton
2a7611e 
Fixes rust-lang#31122.
bors added a commit that referenced this issue Feb 16, 2016
@bors
Auto merge of #31627 - KiChjang:unstable-lint, r=alexcrichton
0f8f7d5 
Fixes #31122.
bors added a commit that referenced this issue Feb 16, 2016
@bors
Auto merge of #31627 - KiChjang:unstable-lint, r=alexcrichton
29e8ac5 
Fixes #31122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @brson @KiChjang