You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The libc merge was a breaking change: c_char on ARM Linux was i8 but is now u8. This is a bugfix, which is fair, it was wrong before. This type is exposed via CStr::as_ptr() however, and there was no obvious way to refer to it, so users would depend on and use the crates.io libc::c_char, which only corresponds if using (old rustc + libc 0.1) or (new rustc + libc 0.2).
Note that os::raw::c_char is still wrong/old, so even using that would break.
It's a bit strange to expect users of `libstd` to require the use of an external crates.io crate to work with standard types. This commit encourages the use `os::raw::c_char` instead, although users are certainly free to use `libc::c_char` if they wish; the test still exists to ensure the two types are identical (though the reported bug only exists on platforms that are not officially tested).
Fixesrust-lang#29774
The libc merge was a breaking change:
c_char
on ARM Linux was i8 but is now u8. This is a bugfix, which is fair, it was wrong before. This type is exposed via CStr::as_ptr() however, and there was no obvious way to refer to it, so users would depend on and use the crates.iolibc::c_char
, which only corresponds if using (old rustc + libc 0.1) or (new rustc + libc 0.2).Note that os::raw::c_char is still wrong/old, so even using that would break.
cc @alexcrichton
The text was updated successfully, but these errors were encountered: