Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fail-unwind machinery to rustc #236

Closed
graydon opened this issue Feb 23, 2011 · 2 comments
Closed

add fail-unwind machinery to rustc #236

graydon opened this issue Feb 23, 2011 · 2 comments
Assignees
@brson
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Milestone
0.1 first support...

Comments

@graydon
Copy link
Contributor

graydon commented Feb 23, 2011

code coming out of rustc can't fail-and-unwind properly. it needs to learn how to.
@ghost ghost assigned espindola May 26, 2011
@pcwalton
Copy link
Contributor

brson is having issues getting LLVM unwinding to work on Windows. Will need to investigate. We may need to add the support to LLVM ourselves.

@ghost ghost assigned brson Sep 7, 2011
brson added a commit that referenced this issue Sep 7, 2011
@brson
Refactor task failure a bit
bb08ffb 
Issue #236
brson added a commit that referenced this issue Sep 7, 2011
@brson
Begin compiling with exceptions enabled
1bd6270 
Issue #236
brson added a commit that referenced this issue Sep 7, 2011
@brson
Rewrite spawn yet again
25ae3d6 
The motivation here is that the bottom of each stack needs to contain a C++
try/catch block so that we can unwind. This is already the case for main, but
not spawned tasks.

Issue #236
brson added a commit that referenced this issue Sep 7, 2011
@brson
Unwind the stack on task failure
c047cfb 
When a task fails, we will throw an exception, then catch it at the bottom of
the stack.

On Windows we don't do this yet because the exception doesn't propagate
correctly.

No cleanups yet.

Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Add upcall_rust_personality
9f4b4d8 
This just wraps __gxx_personality_v0 with our upcall naming convention

Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Use invoke to call (most) rust functions
4bced5e 
No landing pads yet.

Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Add Rust definitions for new LLVM EH instructions
5e4637b 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Add landing pads to invokes
4eb3ce3 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Zero locals that have initializers that might fail
587b863 
This will avoid running cleanups on uninitialized memory

Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Run cleanups during unwinding
4c9eee8 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Invoke upcall_fail
4fba02c 
This allows landing pads to be generated around fail statements

Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Add a number of unwinding tests
f99cf2d 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Begin valgrinding some run-fail tests that unwind correctly
f28bbb2 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Remove the no-valgrind test directive now that unwinding is more worky
e8a1635 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Add some FIXMEs about unwinding implementation
53f7d61 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Add an XFAILed test for failing destructors
5b7145a 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Invoke put functions
1181943 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Remove unused task_exit function
6f6f361 
Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Zero locals when the initializer might call a function
d267e74 
The function might fail, leaving the local uninitialized

Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Remove hack_allow_leaks
22001d1 
Happy to close the loop on this one.

Issue #236
brson added a commit that referenced this issue Sep 12, 2011
@brson
Add some more unwind tests
69d6e0d 
They worked without modifications, but I wrote them so we're keeping them.

Issue #236
@brson
Copy link
Contributor

brson commented Sep 12, 2011

Implemented for Linux and Mac, but not efficient. No implementation for Windows. Will open additional issues.

@brson brson closed this as completed Sep 12, 2011
@lifthrasiir lifthrasiir mentioned this issue Nov 12, 2014
Closed
oli-obk added a commit to oli-obk/rust that referenced this issue Jul 19, 2017
@oli-obk
Merge pull request rust-lang#236 from oli-obk/pointers
40755ec 
Use a wrapper type to differentiate between `PrimVal` and pointers
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@Nercury
Use now available link name "signal" instead of "bsd_signal".
b2eec24 
Fixes rust-lang#236.
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@bors
Auto merge of rust-lang#237 - Nercury:use-signal-instead-of-bsd-signa…
60f90cf 
…l, r=alexcrichton

Use now available link name "signal" instead of "bsd_signal"

On android, the `bsd_signal` is gone, the `signal` is available.

While this is the most obvious solution, I am not sure of a few things:
- How are we going to keep compatibility with older NDKs where `signal` does not exist;
- Was something dependent on this being different on android and thus would break (for example, the rust compiler uses this function, so it may break somewhere).

Fixes rust-lang#236.
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@Havvy
Merge pull request rust-lang#236 from alercah/deref-coercion
b8c6072 
Document that &mut T can deref-coerce to &U.
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Correct CacheLICM behavior when not the outermost loop (rust-lang#236)
b1bd36a 
* Allow cachelicm within subregion

* Correct CacheLICM
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Mar 7, 2023
@antoyo
Merge pull request rust-lang#236 from GuillaumeGomez/install-doc
cc5c387 
Improve installation documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
0.1 first supported public release
Development

No branches or pull requests
4 participants
@graydon @espindola @brson @pcwalton