Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something about std::deque #2343

Closed
catamorphism opened this issue May 3, 2012 · 1 comment
Closed

Do something about std::deque #2343

catamorphism opened this issue May 3, 2012 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

It's not used anywhere (it was imported in resolve, but the import wasn't needed) and a comment at the top says "untested... Likely buggy." Though there actually are some tests within the module, I'm not sure if it should be in std if it's been sitting unused for a long time?

In any case, if it does get kept, there's a FIXME before deque::create: "eventually, a proper datatype plus an exported impl would be preferrable" -- that should be addressed.

@eholk
Copy link
Contributor

eholk commented May 18, 2012

A deque seems like something that should definitely be in any standard library, so I'd vote for keeping and fixing this one. Unfortunately, it doesn't work at the moment (#2383)

bors added a commit that referenced this issue Feb 17, 2013
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

3 participants