Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep-info includes all transitvely linked files #23089

Closed
alexcrichton opened this issue Mar 5, 2015 · 2 comments · Fixed by #23090
Closed

dep-info includes all transitvely linked files #23089

alexcrichton opened this issue Mar 5, 2015 · 2 comments · Fixed by #23090

Comments

@alexcrichton
Copy link
Member

I think that the changes in #22235 mean that the dep-info output includes too many files now:

$ touch foo.rs
$ rustc foo.rs --crate-type lib --emit=dep-info
$ cat foo.d

output

cc @michaelwoerister

@michaelwoerister
Copy link
Member

Yes, driver::write_out_deps() probably needs to add a FileMap::is_imported() check to filter out files from other crates. I haven't had time to look into this in detail though.

On March 5, 2015 11:38:23 PM CET, Alex Crichton [email protected] wrote:

I think that the changes in #22235 mean that the dep-info output
includes too many files now:

$ touch foo.rs
$ rustc foo.rs --crate-type lib --emit=dep-info
$ cat foo.d

output

cc @michaelwoerister


Reply to this email directly or view it on GitHub:
#23089

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@alexcrichton
Copy link
Member Author

No worries! I did precisely that in #23090 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants