Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require impls next to structs #22563

Closed
brson opened this issue Feb 20, 2015 · 0 comments · Fixed by #22172
Closed

Don't require impls next to structs #22563

brson opened this issue Feb 20, 2015 · 0 comments · Fixed by #22172
Labels
A-resolve Area: Name resolution

Comments

@brson
Copy link
Contributor

brson commented Feb 20, 2015

tracking rust-lang/rfcs#735
@eddyb eddyb mentioned this issue Feb 20, 2015
Merged
@kmcallister kmcallister added the A-resolve Area: Name resolution label Feb 21, 2015
bors added a commit that referenced this issue Feb 24, 2015
@bors
Auto merge of #22172 - eddyb:almost-there, r=nikomatsakis
0bd1565 
Adds `<module::Type>::method` support and makes `module::Type::method` a shorthand for it.
This is most of #16293, except that chaining multiple associated types is not yet supported.
It also fixes #22563 as `impl`s are no longer treated as modules in resolve.

Unfortunately, this is still a *[breaking-change]*:
* If you used a global path to a primitive type, i.e. `::bool`, `::i32` etc. - that was a bug I had to fix.
Solution: remove the leading `::`.
* If you passed explicit `impl`-side type parameters to an inherent method, e.g.:
```rust
struct Foo<T>(T);
impl<A, B> Foo<(A, B)> {
    fn pair(a: A, b: B) -> Foo<(A, B)> { Foo((a, b)) }
}
Foo::<A, B>::pair(a, b)
// Now that is sugar for:
<Foo<A, B>>::pair(a, b)
// Which isn't valid because `Foo` has only one type parameter.
// Solution: replace with:
Foo::<(A, B)>::pair(a, b)
// And, if possible, remove the explicit type param entirely:
Foo::pair(a, b)
```
* If you used the `QPath`-related `AstBuilder` methods @hugwijst added in #21943.
The methods still exist, but `QPath` was replaced by `QSelf`, with the actual path stored separately.
Solution: unpack the pair returned by `cx.qpath` to get the two arguments for `cx.expr_qpath`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name resolution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Partial implementation for UFCS trait-less associated paths. eddyb/rust
2 participants
@brson @kmcallister