Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change suffixes to isize and usize #22496

Closed
nikomatsakis opened this issue Feb 18, 2015 · 5 comments · Fixed by #22497
Closed

Change suffixes to isize and usize #22496

nikomatsakis opened this issue Feb 18, 2015 · 5 comments · Fixed by #22497
Assignees
Labels
A-parser Area: The parsing of Rust source code to an AST

Comments

@nikomatsakis
Copy link
Contributor

Tracking issue for rust-lang/rfcs#573

@kmcallister kmcallister added the A-parser Area: The parsing of Rust source code to an AST label Feb 19, 2015
bors added a commit that referenced this issue Feb 19, 2015
The old suffixes now issue warnings unless a feature-gate is given.

Fixes #22496.

r? @alexcrichton
@pnkfelix
Copy link
Member

Reopening, apparently us/is is still being silently accepted?

Example on playpen:

fn main() {
    let foo = 2us;
    println!("foo: {}", foo);
}

See also http://internals.rust-lang.org/t/how-did-the-is-us-suffixes-survive/1871

@pnkfelix
Copy link
Member

Nominating: I want to figure out if a fix for this needs to be backported to beta, or to 1.0, or if we are stuck accepting it for now (or forever).

@nikomatsakis
Copy link
Contributor Author

The problem seems to be in this commit: 54f16b8

@nikomatsakis
Copy link
Contributor Author

Specifically here.

@brson brson self-assigned this Apr 14, 2015
@brson
Copy link
Contributor

brson commented Apr 14, 2015

I'll put a patch together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area: The parsing of Rust source code to an AST
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants