Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON 'List' name inconsistent with JSON specification #19010

Closed
frewsxcv opened this issue Nov 16, 2014 · 3 comments · Fixed by #19114
Closed

JSON 'List' name inconsistent with JSON specification #19010

frewsxcv opened this issue Nov 16, 2014 · 3 comments · Fixed by #19114

Comments

@frewsxcv
Copy link
Member

In the Rust JSON serialization module, an ordered list of values is referred to as a List. In the official JSON specification, an ordered list of values is called an Array. I propose we rename List to Array for the sake of consistency with the original specification. If approved, I'd be happy to make the change and submit a pull request.

@gamazeps
Copy link
Contributor

Seems ok to me (plus it's implemented with an Vector, do it's really an array).
Do your PR :)

@frewsxcv
Copy link
Member Author

Great, I'll try to get that done tonight

frewsxcv added a commit to frewsxcv/rust that referenced this issue Nov 19, 2014
@frewsxcv
Copy link
Member Author

Went faster/easier than I expected. Pull request can be found here: #19114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants