Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the doc/master S3 folder to doc/nightly #17398

Closed
brson opened this issue Sep 19, 2014 · 13 comments
Closed

Rename the doc/master S3 folder to doc/nightly #17398

brson opened this issue Sep 19, 2014 · 13 comments
Assignees
@edunham
Labels
P-low Low priority

Comments

@brson
Copy link
Contributor

brson commented Sep 19, 2014

If the release channel is going to be called nightly we might as well fix this to avoid confusion.
@brson
Copy link
Contributor Author

brson commented Sep 19, 2014

cc @alexcrichton @steveklabnik

This was referenced Sep 19, 2014
Closed
Closed
@brson
Copy link
Contributor Author

brson commented Sep 19, 2014

This is currently being managed in nginx rewriting rules, but the s3 folder is called master. I will probably change it sometime in the course of release channel automation upgrades.

@alexcrichton
Copy link
Member

This is done.

@alexcrichton
Copy link
Member

Ah, but renaming the S3 folder is not.

@alexcrichton alexcrichton reopened this Sep 19, 2014
@steveklabnik
Copy link
Member

Seems legit.

@steveklabnik
Copy link
Member

Given that http://doc.rust-lang.org/nightly/ resolves, has this been finished?

@alexcrichton alexcrichton changed the title Change doc.rust-lang.org/master to doc.rust-lang.org/nightly Rename the doc/master S3 folder to doc/nightly Oct 27, 2014
@alexcrichton
Copy link
Member

Not quite just yet, but I've updated the title with the remaining todo item.

@steveklabnik
Copy link
Member

What about now?

@steveklabnik
Copy link
Member

@edunham @alexcrichton was this fixed?

@alexcrichton
Copy link
Member

This has not been fixed

@brson brson added the P-low Low priority label Aug 22, 2016
@edunham
Copy link
Member

edunham commented Aug 22, 2016

TODO fix the Buildbot rule that's rewriting stuff

@edunham edunham self-assigned this Aug 22, 2016
edunham pushed a commit to edunham/rust-buildbot that referenced this issue Feb 7, 2017
write to doc/nightly, not doc/master
4ca2d86 
fixes rust-lang/rust#17398
@edunham edunham mentioned this issue Feb 7, 2017
Closed
@Mark-Simulacrum
Copy link
Member

So @edunham's PR was never merged, and I don't know the current status here.

cc @brson @alexcrichton

@alexcrichton
Copy link
Member

Oh hey I fixed this!

lnicola pushed a commit to lnicola/rust that referenced this issue Jun 23, 2024
@bors
Auto merge of rust-lang#17398 - Veykril:bogus-file, r=Veykril
031d37f 
internal: Remove FileId::BOGUS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edunham edunham

Labels
P-low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

write to doc/nightly, not doc/master edunham/rust-buildbot
5 participants
@steveklabnik @alexcrichton @brson @edunham @Mark-Simulacrum