Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expected error scanner is too imprecise #1476

Closed
nikomatsakis opened this issue Jan 9, 2012 · 0 comments
Closed

expected error scanner is too imprecise #1476

nikomatsakis opened this issue Jan 9, 2012 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
old 1.0 milestone

Comments

@nikomatsakis
Copy link
Contributor

The code in compiletest which scans for expected errors when you use the //! mechanism to associate an error with a particular line is not very smart. It just looks for a filename, line number, and the string error or warning. This sometimes causes it to fail tests that do not deserve to fail. For example, if you have a line of code like:

log(error, x); //! ERROR some expected error

and the compiler reports the expected error, you will get a test failure. This is because the compiler also reports the line of code that caused the error, and the compiletest code sees the error string in log(error, x) and thinks that this line of code is a second error report which was not expected.
@ghost ghost assigned brson Apr 12, 2012
@nikomatsakis nikomatsakis mentioned this issue May 18, 2012
Closed
0c0w3 added a commit to 0c0w3/rust that referenced this issue Sep 11, 2012
@0c0w3
Improve unexpected error scanner for compile-fail tests (Closes rust-…
d90b481 
…lang#1476)
@0c0w3 0c0w3 mentioned this issue Sep 11, 2012
Closed
@brson brson closed this as completed in 98bd4a9 Sep 12, 2012
@joshtriplett joshtriplett mentioned this issue Oct 7, 2022
Merged
joshtriplett added a commit to joshtriplett/rust that referenced this issue Oct 7, 2022
@joshtriplett
Update rustc-dev-guide
10bd656 
- .gitattributes: Mark minified javascript as binary to filter greps
- fix very minor punctuation typo
- diagnostic structs: derive on enum (rust-lang#1477)
- Update running tests with the new flags (rust-lang#1476)
- Rename typeck to hir_analysis (rust-lang#1475)
- fix typo and make paragraph consistent (rust-lang#1474)
- Update about-this-guide.md
- Link to the correct page in "about this guide"
- Update r-a config suggestions
- don't refer to the compile-time interpreter as "Miri" (rust-lang#1471)
- UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558
- Update mdbook and its extensions versions
- Remove unmaintained action
- Update some actions versions
- Fix some typos

Update motivated in large part by the most recent commit, to fix `git
grep`.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Oct 8, 2022
@Dylan-DPC
Rollup merge of rust-lang#102788 - joshtriplett:bump-rustc-dev-guide,…
870032b 
… r=ehuss

Update rustc-dev-guide

- .gitattributes: Mark minified javascript as binary to filter greps
- fix very minor punctuation typo
- diagnostic structs: derive on enum (rust-lang#1477)
- Update running tests with the new flags (rust-lang#1476)
- Rename typeck to hir_analysis (rust-lang#1475)
- fix typo and make paragraph consistent (rust-lang#1474)
- Update about-this-guide.md
- Link to the correct page in "about this guide"
- Update r-a config suggestions
- don't refer to the compile-time interpreter as "Miri" (rust-lang#1471)
- UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558
- Update mdbook and its extensions versions
- Remove unmaintained action
- Update some actions versions
- Fix some typos

Update motivated in large part by the most recent commit, to fix `git
grep`.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 8, 2022
@matthiaskrgr
Rollup merge of rust-lang#102788 - joshtriplett:bump-rustc-dev-guide,…
c2bd2f3 
… r=ehuss

Update rustc-dev-guide

- .gitattributes: Mark minified javascript as binary to filter greps
- fix very minor punctuation typo
- diagnostic structs: derive on enum (rust-lang#1477)
- Update running tests with the new flags (rust-lang#1476)
- Rename typeck to hir_analysis (rust-lang#1475)
- fix typo and make paragraph consistent (rust-lang#1474)
- Update about-this-guide.md
- Link to the correct page in "about this guide"
- Update r-a config suggestions
- don't refer to the compile-time interpreter as "Miri" (rust-lang#1471)
- UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558
- Update mdbook and its extensions versions
- Remove unmaintained action
- Update some actions versions
- Fix some typos

Update motivated in large part by the most recent commit, to fix `git
grep`.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Oct 8, 2022
@Dylan-DPC
Rollup merge of rust-lang#102788 - joshtriplett:bump-rustc-dev-guide,…
dcc9316 
… r=ehuss

Update rustc-dev-guide

- .gitattributes: Mark minified javascript as binary to filter greps
- fix very minor punctuation typo
- diagnostic structs: derive on enum (rust-lang#1477)
- Update running tests with the new flags (rust-lang#1476)
- Rename typeck to hir_analysis (rust-lang#1475)
- fix typo and make paragraph consistent (rust-lang#1474)
- Update about-this-guide.md
- Link to the correct page in "about this guide"
- Update r-a config suggestions
- don't refer to the compile-time interpreter as "Miri" (rust-lang#1471)
- UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558
- Update mdbook and its extensions versions
- Remove unmaintained action
- Update some actions versions
- Fix some typos

Update motivated in large part by the most recent commit, to fix `git
grep`.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 8, 2022
@matthiaskrgr
Rollup merge of rust-lang#102788 - joshtriplett:bump-rustc-dev-guide,…
140fe04 
… r=ehuss

Update rustc-dev-guide

- .gitattributes: Mark minified javascript as binary to filter greps
- fix very minor punctuation typo
- diagnostic structs: derive on enum (rust-lang#1477)
- Update running tests with the new flags (rust-lang#1476)
- Rename typeck to hir_analysis (rust-lang#1475)
- fix typo and make paragraph consistent (rust-lang#1474)
- Update about-this-guide.md
- Link to the correct page in "about this guide"
- Update r-a config suggestions
- don't refer to the compile-time interpreter as "Miri" (rust-lang#1471)
- UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558
- Update mdbook and its extensions versions
- Remove unmaintained action
- Update some actions versions
- Fix some typos

Update motivated in large part by the most recent commit, to fix `git
grep`.
bjorn3 added a commit to bjorn3/rust that referenced this issue Apr 5, 2024
@bjorn3
Merge pull request rust-lang#1476 from taiki-e/unchecked-shift
64d6da5 
Fix ICE on unchecked shift
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@tedinski
Bump to 0.8 (rust-lang#1476)
b0aeb2b
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@pietroalbini
Update running tests with the new flags (rust-lang#1476)
0f6090a
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@pietroalbini
Update running tests with the new flags (rust-lang#1476)
7722f6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@brson @nikomatsakis