Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce the file system hierarchy more strictly for modules #14180

Closed
alexcrichton opened this issue May 13, 2014 · 2 comments · Fixed by #14251
Closed

Enforce the file system hierarchy more strictly for modules #14180

alexcrichton opened this issue May 13, 2014 · 2 comments · Fixed by #14251
Labels
A-parser Area: The parsing of Rust source code to an AST B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Milestone
1.0

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#63
@alexcrichton
Copy link
Member Author

Nominating.

@pnkfelix
Copy link
Member

P-backcompat-lang, 1.0.

@pnkfelix pnkfelix added this to the 1.0 milestone May 15, 2014
@alexcrichton alexcrichton mentioned this issue May 16, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 17, 2014
@alexcrichton
syntax: Tighten search paths for inner modules
4e9e091 
This is an implementation of RFC 16. A module can now only be loaded if the
module declaring `mod name;` "owns" the current directory. A module is
considered as owning its directory if it meets one of the following criteria:

* It is the top-level crate file
* It is a `mod.rs` file
* It was loaded via `#[path]`
* It was loaded via `include!`
* The module was declared via an inline `mod foo { ... }` statement

For example, this directory structure is now invalid

    // lib.rs
    mod foo;

    // foo.rs
    mod bar;

    // bar.rs;
    fn bar() {}

With this change `foo.rs` must be renamed to `foo/mod.rs`, and `bar.rs` must be
renamed to `foo/bar.rs`. This makes it clear that `bar` is a submodule of `foo`,
and can only be accessed through `foo`.

RFC: 0016-module-file-system-hierarchy
Closes rust-lang#14180

[breaking-change]
bors added a commit that referenced this issue May 19, 2014
@bors
auto merge of #14251 : alexcrichton/rust/hierarchy, r=huonw
ed15677 
This is an implementation of RFC 16. A module can now only be loaded if the
module declaring `mod name;` "owns" the current directory. A module is
considered as owning its directory if it meets one of the following criteria:

* It is the top-level crate file
* It is a `mod.rs` file
* It was loaded via `#[path]`
* It was loaded via `include!`
* The module was declared via an inline `mod foo { ... }` statement

For example, this directory structure is now invalid

    // lib.rs
    mod foo;

    // foo.rs
    mod bar;

    // bar.rs;
    fn bar() {}

With this change `foo.rs` must be renamed to `foo/mod.rs`, and `bar.rs` must be
renamed to `foo/bar.rs`. This makes it clear that `bar` is a submodule of `foo`,
and can only be accessed through `foo`.

RFC: 0016-module-file-system-hierarchy
Closes #14180

[breaking-change]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

syntax: Tighten search paths for inner modules alexcrichton/rust
2 participants
@alexcrichton @pnkfelix