Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Add gui-test for "copy item path" button #137082

Open
aDotInTheVoid opened this issue Feb 15, 2025 · 0 comments · May be fixed by #137539
Open

rustdoc: Add gui-test for "copy item path" button #137082

aDotInTheVoid opened this issue Feb 15, 2025 · 0 comments · May be fixed by #137539
Assignees
@GuillaumeGomez
Labels
A-rustdoc-js Area: Rustdoc's JS front-end E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@aDotInTheVoid
Copy link
Member

Ideally, we should have a test for this in tests/rustdoc-gui, but it doesn't seem like there's a way to inspect the clipboard. CC @GuillaumeGomez

I don't think it's worth blocking this fix on having a test, but we should add one.

Originally posted by @aDotInTheVoid in #137068 (comment)

#137048 was fixed in #137068 but without a regression test. This issue it to track adding that test.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 15, 2025
@aDotInTheVoid aDotInTheVoid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. A-rustdoc-js Area: Rustdoc's JS front-end T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 15, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 24, 2025
@GuillaumeGomez
Add rustdoc-gui regression test for rust-lang#137082
592028a
@GuillaumeGomez GuillaumeGomez linked a pull request Feb 24, 2025 that will close this issue
Open
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 24, 2025
@GuillaumeGomez
Rollup merge of rust-lang#137539 - GuillaumeGomez:copy-content-tests,…
82ee023 
… r=notriddle

 Add rustdoc-gui regression test for rust-lang#137082

Fixes rust-lang#137082.

Added new commands in `browser-ui-test` allowing us to add a regression test for rust-lang#137082 and also another to copy code examples content.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez mentioned this issue Feb 24, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 24, 2025
@bors
Auto merge of rust-lang#137545 - GuillaumeGomez:rollup-ss95p06, r=Gui…
771f3a0 
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#136775 (Update `String::from_raw_parts` safety requirements)
 - rust-lang#137373 (Compile run-make-support and run-make tests with the bootstrap compiler)
 - rust-lang#137489 (remove `#[rustc_intrinsic_must_be_overridde]`)
 - rust-lang#137493 (configure.py: don't instruct user to run nonexistent program)
 - rust-lang#137516 (remove some unnecessary rustc_const_unstable)
 - rust-lang#137527 (Update stdarch)
 - rust-lang#137530 (DWARF mixed versions with LTO on MIPS)
 - rust-lang#137539 ( Add rustdoc-gui regression test for rust-lang#137082 )
 - rust-lang#137543 (std: Fix another new symlink test on Windows)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this issue Feb 25, 2025
@fmease
Rollup merge of rust-lang#137539 - GuillaumeGomez:copy-content-tests,…
8462d56 
… r=notriddle

 Add rustdoc-gui regression test for rust-lang#137082

Fixes rust-lang#137082.

Added new commands in `browser-ui-test` allowing us to add a regression test for rust-lang#137082 and also another to copy code examples content.

r? `@notriddle`
@fmease fmease mentioned this issue Feb 25, 2025
Open
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 25, 2025
@bors
Auto merge of rust-lang#137608 - fmease:rollup-h4siso6, r=fmease
85abb27 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#137370 (adjust_abi: make fallback logic for ABIs a bit easier to read)
 - rust-lang#137444 (Improve behavior of `IF_LET_RESCOPE` around temporaries and place expressions)
 - rust-lang#137464 (Fix invalid suggestion from type error for derive macro)
 - rust-lang#137539 ( Add rustdoc-gui regression test for rust-lang#137082 )
 - rust-lang#137576 (Don't doc-comment BTreeMap<K, SetValZST, A>)
 - rust-lang#137595 (remove `simd_fpow` and `simd_fpowi`)
 - rust-lang#137600 (type_ir: remove redundant part of comment)
 - rust-lang#137602 (feature: fix typo in attribute description)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-js Area: Rustdoc's JS front-end E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rustdoc-gui regression test for #137082 GuillaumeGomez/rust
3 participants
@GuillaumeGomez @aDotInTheVoid @rustbot