Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutorial mentions variable-binding before explaining it #13570

Closed
zookoatleastauthoritycom opened this issue Apr 17, 2014 · 2 comments
Closed

tutorial mentions variable-binding before explaining it #13570

zookoatleastauthoritycom opened this issue Apr 17, 2014 · 2 comments

Comments

@zookoatleastauthoritycom
Copy link

The tutorial's section on pattern matching (http://static.rust-lang.org/doc/master/tutorial.html#pattern-matching) shows some patterns without any variable-bindings in them, and then mentions "so long as every pattern binds the same set of variables". This caused my partner, with whom I am currently working through the tutorial, to stop because she thought she must have missed something. a few sentences later in the tutorial variable bindings are introduced by example, and explained.
@zookoatleastauthoritycom
Copy link
Author

Perhaps this could be fixed simply by adding "(see below)" after the mention of variable-bindings.

zookoatleastauthoritycom pushed a commit to zookoatleastauthoritycom/rust that referenced this issue May 12, 2014
add "(see below)" to a reference to a new concept
45c9493 
This is because I observed someone reading the tutorial who thought they'd
missed something when they got to the mention of variable bindings.

Fixes rust-lang#13570 .
Closed
@steveklabnik
Copy link
Member

I think this issue can be closed. The tutorial is getting re-done by me, starting today.

zookoatleastauthoritycom pushed a commit to zookoatleastauthoritycom/rust that referenced this issue Jun 25, 2014
add "(see below)" to a reference to a new concept
d6ea862 
This is because I observed someone reading the tutorial who thought they'd
missed something when they got to the mention of variable bindings.

This patch doesn't reflow the paragraphs so that you can see the semantic
change that I made, and a subsequent patch will reflow this paragraph.

Fixes rust-lang#13570.
Merged
bors added a commit that referenced this issue Jun 27, 2014
@bors
auto merge of #15166 : zookoatleastauthoritycom/rust/13570-add-see-be…
1702194 
…low-to-a-reference-to-a-new-concept-2, r=huonw

This is the same patch as submitted to #13570 and #14124, but with @pnkfelix's comment (#14124 (comment)) addressed, and with reflow as a separate commit. I'm submitting it in case @steveklabnik hasn't yet merged a rewrite of the tutorial (#13570 (comment)), in which case this patch might as well be merged into the old tutorial.
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Nov 16, 2022
@bors
Auto merge of rust-lang#13570 - Veykril:dedup-crates-for, r=Veykril
8a633fe 
minor: Remove code duplication
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 7, 2024
@bors
Auto merge of rust-lang#13570 - Kijewski:pr-stray-comma, r=xFrednet
5873cb9 
docs: remove stray comma

changelog: none

the typo was (seemingly) ignored by browsers, so the change isn't visible to users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add "(see below)" to a reference to a new concept zookoatleastauthoritycom/rust
3 participants
@steveklabnik @alexcrichton @zookoatleastauthoritycom