Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows nightlies have statically linked rustc/rustdoc binaries #13491

Closed
alexcrichton opened this issue Apr 13, 2014 · 2 comments
Closed

Windows nightlies have statically linked rustc/rustdoc binaries #13491

alexcrichton opened this issue Apr 13, 2014 · 2 comments
Labels
O-windows Operating system: Windows

Comments

@alexcrichton
Copy link
Member

They're around 40MB in size, which would be ridiculously large for a dynamically linked binary.

I've confirmed that the OSX/linux nightlies are indeed dynamically linked.
@alexcrichton alexcrichton mentioned this issue Apr 13, 2014
Closed
@alexcrichton
Copy link
Member Author

This appears to be because we install from stage3 on windows, which is hard-wired to produce statically linked binaries because I thought stage3 was only used for snapshots.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 14, 2014
@alexcrichton
mk: Change windows to install from stage2
4ba889b 
In the past, windows was installed from stage3 to guarantee convergence between
the host and target artifacts, but syntax extensions on all platforms are
currently relying on convergence, so special casing this one platform has become
less relevant over time.

This will also have the added benefit of dealing with rust-lang#13474 and rust-lang#13491. These
issues will be closed after next next nightly is confirmed to fix them.
@alexcrichton alexcrichton mentioned this issue Apr 14, 2014
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 16, 2014
@alexcrichton
mk: Change windows to install from stage2
efec34a 
In the past, windows was installed from stage3 to guarantee convergence between
the host and target artifacts, but syntax extensions on all platforms are
currently relying on convergence, so special casing this one platform has become
less relevant over time.

This will also have the added benefit of dealing with rust-lang#13474 and rust-lang#13491. These
issues will be closed after next next nightly is confirmed to fix them.
@alexcrichton
Copy link
Member Author

Closed by efec34a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexcrichton