Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avr-rjmp-offset is flaky on x86_64-mingw #133480

Open
jieyouxu opened this issue Nov 25, 2024 · 1 comment
Open

avr-rjmp-offset is flaky on x86_64-mingw #133480

jieyouxu opened this issue Nov 25, 2024 · 1 comment
Labels
A-linkers Area: linkers... you gotta love linkers A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. C-external-bug Category: issue that is caused by bugs in software beyond our control I-flaky-test Issue: A test is flaky/unreliable/spuriously fails O-AVR Target: AVR processors (ATtiny, ATmega, etc.) O-windows-gnu Toolchain: GNU, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Nov 25, 2024

This test seems to be failing somewhat often:

All on x86_64-mingw. Can we maybe disable it on x86_64-mingw until it is fixed?

Originally posted by @ehuss in #131755 (comment)

I think the linker is crashing...

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 25, 2024
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-AVR Target: AVR processors (ATtiny, ATmega, etc.) A-run-make Area: port run-make Makefiles to rmake.rs A-linkers Area: linkers... you gotta love linkers I-flaky-test Issue: A test is flaky/unreliable/spuriously fails and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 25, 2024
@jieyouxu jieyouxu added C-bug Category: This is a bug. O-windows Operating system: Windows C-external-bug Category: issue that is caused by bugs in software beyond our control labels Nov 26, 2024
@ChrisDenton ChrisDenton added O-windows-gnu Toolchain: GNU, Operating system: Windows and removed O-windows Operating system: Windows labels Nov 26, 2024
@ChrisDenton
Copy link
Member

ChrisDenton commented Nov 26, 2024

Also tagging as LLVM because the error messages asks us to submit a bug report.

Error message
=== STDERR ===
error: linking with `rust-lld` failed: exit code: 0xc0000005
error: linking with `rust-lld` failed: exit code: 0xc0000005
  |
  = note: "rust-lld" "-flavor" "gnu" "C:\\a\\_temp\\msys64\\tmp\\rustc2fOg1x\\symbols.o" "compiled.avr_rjmp_offsets.ab053966543a1f9f-cgu.0.rcgu.o" "--as-needed" "-Bdynamic" "-z" "noexecstack" "-L" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\avr-rjmp-offset\\rmake_out" "-o" "compiled" "--gc-sections" "--entry=main"
  = note: PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.␍
          Exception Code: 0xC0000005␍
          0x00007FFFE67B784C, C:\Windows\SYSTEM32\ntdll.dll(0x00007FFFE67A0000) + 0x1784C byte(s), RtlEnterCriticalSection() + 0x3CC byte(s)␍
          0x00007FFFE67BB550, C:\Windows\SYSTEM32\ntdll.dll(0x00007FFFE67A0000) + 0x1B550 byte(s), RtlGetCurrentServiceSessionId() + 0xBF0 byte(s)␍
          0x00007FFFE67BA8C1, C:\Windows\SYSTEM32\ntdll.dll(0x00007FFFE67A0000) + 0x1A8C1 byte(s), RtlFreeHeap() + 0x51 byte(s)␍
          0x00007FFFE48AC69C, C:\Windows\System32\msvcrt.dll(0x00007FFFE4890000) + 0x1C69C byte(s), free() + 0x1C byte(s)␍
          0x00007FFFE1F24AF1, C:\a\rust\rust\mingw64\bin\libwinpthread-1.dll(0x00007FFFE1F20000) + 0x4AF1 byte(s), pthread_tls_init() + 0x701 byte(s)␍
          0x00007FFFE1F24C15, C:\a\rust\rust\mingw64\bin\libwinpthread-1.dll(0x00007FFFE1F20000) + 0x4C15 byte(s), pthread_create_wrapper() + 0xC5 byte(s)␍
          0x00007FFFE48CDFD4, C:\Windows\System32\msvcrt.dll(0x00007FFFE4890000) + 0x3DFD4 byte(s), _beginthreadex() + 0x134 byte(s)␍
          0x00007FFFE48CE0AC, C:\Windows\System32\msvcrt.dll(0x00007FFFE4890000) + 0x3E0AC byte(s), _endthreadex() + 0xAC byte(s)␍
          0x00007FFFE4E94CB0, C:\Windows\System32\KERNEL32.DLL(0x00007FFFE4E80000) + 0x14CB0 byte(s), BaseThreadInitThunk() + 0x10 byte(s)␍
          0x00007FFFE681ECDB, C:\Windows\SYSTEM32\ntdll.dll(0x00007FFFE67A0000) + 0x7ECDB byte(s), RtlUserThreadStart() + 0x2B byte(s)␍

@ChrisDenton ChrisDenton added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Nov 26, 2024
jhpratt added a commit to jhpratt/rust that referenced this issue Nov 26, 2024
Disable `avr-rjmp-offset` on Windows for now

The linker has been randomly crashing on `x86_64-mingw` that's causing spurious failures (rust-lang#133480). Disable this test on Windows for now.

cc `@jfrimmel` (nothing actionable, just FYI because linker gonna linker)
cc `@ehuss` (who noticed this)

r? compiler (or anyone really)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 26, 2024
Disable `avr-rjmp-offset` on Windows for now

The linker has been randomly crashing on `x86_64-mingw` that's causing spurious failures (rust-lang#133480). Disable this test on Windows for now.

cc `@jfrimmel` (nothing actionable, just FYI because linker gonna linker)
cc `@ehuss` (who noticed this)

r? compiler (or anyone really)
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 26, 2024
Rollup merge of rust-lang#133481 - jieyouxu:avr-jmp-linker, r=saethlin

Disable `avr-rjmp-offset` on Windows for now

The linker has been randomly crashing on `x86_64-mingw` that's causing spurious failures (rust-lang#133480). Disable this test on Windows for now.

cc `@jfrimmel` (nothing actionable, just FYI because linker gonna linker)
cc `@ehuss` (who noticed this)

r? compiler (or anyone really)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linkers Area: linkers... you gotta love linkers A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. C-external-bug Category: issue that is caused by bugs in software beyond our control I-flaky-test Issue: A test is flaky/unreliable/spuriously fails O-AVR Target: AVR processors (ATtiny, ATmega, etc.) O-windows-gnu Toolchain: GNU, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants