Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for wasm32-emscripten ui test failures #131738

Open
3 of 7 tasks
hoodmane opened this issue Oct 15, 2024 · 0 comments
Open
3 of 7 tasks

Tracking issue for wasm32-emscripten ui test failures #131738

hoodmane opened this issue Oct 15, 2024 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL!

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Oct 15, 2024 •
edited
Loading

These are the tests that are failing after #131705:
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 15, 2024
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 15, 2024
hoodmane added a commit to hoodmane/rust that referenced this issue Oct 16, 2024
@hoodmane
Emscripten: Xfail backtrace ui tests
476ea45 
It is possible to link libunwind and use the normal backtrace code, but it fails
to symbolize stack traces. I investigated and could get the list of instruction
pointers and symbol names, but I'm not sure how to use the dwarf info to map
from instruction pointer to source location. In any case, fixing this is
probably not a high priority.

See rust-lang#131738
@hoodmane hoodmane mentioned this issue Oct 16, 2024
Merged
Urgau added a commit to Urgau/rust that referenced this issue Oct 16, 2024
@Urgau
Rollup merge of rust-lang#131776 - hoodmane:emscripten-xfail-backtrac…
d6c51cf 
…e-tests, r=jieyouxu

Emscripten: Xfail backtrace ui tests

It is possible to link libunwind and use the normal backtrace code, but it fails to symbolize stack traces. I investigated and could get the list of instruction pointers and symbol names, but I'm not sure how to use the dwarf info to map from instruction pointer to source location. In any case, fixing this is not a high priority.

See rust-lang#131738

r?jieyouxu
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 16, 2024
@matthiaskrgr
Rollup merge of rust-lang#131776 - hoodmane:emscripten-xfail-backtrac…
c8ec8e6 
…e-tests, r=jieyouxu

Emscripten: Xfail backtrace ui tests

It is possible to link libunwind and use the normal backtrace code, but it fails to symbolize stack traces. I investigated and could get the list of instruction pointers and symbol names, but I'm not sure how to use the dwarf info to map from instruction pointer to source location. In any case, fixing this is not a high priority.

See rust-lang#131738

r?jieyouxu
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 16, 2024
@rust-timer
Unrolled build for rust-lang#131776
9775c17 
Rollup merge of rust-lang#131776 - hoodmane:emscripten-xfail-backtrace-tests, r=jieyouxu

Emscripten: Xfail backtrace ui tests

It is possible to link libunwind and use the normal backtrace code, but it fails to symbolize stack traces. I investigated and could get the list of instruction pointers and symbol names, but I'm not sure how to use the dwarf info to map from instruction pointer to source location. In any case, fixing this is not a high priority.

See rust-lang#131738

r?jieyouxu
@purplesyringa purplesyringa mentioned this issue Jan 31, 2025
Merged
jhpratt added a commit to jhpratt/rust that referenced this issue Feb 10, 2025
@jhpratt
Rollup merge of rust-lang#136353 - purplesyringa:libtest-instant-wasm…
8927439 
…, r=Mark-Simulacrum

fix(libtest): Enable Instant on Emscripten targets

`Instant::now()` works correctly on Emscripten since rust-lang/libc#3962. All wasm-family targets with OS support can now handle instants.

Improves rust-lang#131738.

~~This changes the behavior of libtest on `unknown-unknown`/`unknown-none` wasm targets, but as far as I can see, libtest doesn't support them anyway. (Can anyone double-check?)~~ UPD: this patch no longer affects `unknown-unknown` targets.

`@rustbot` label +A-libtest +T-testing-devex +O-emscripten +O-wasm -needs-triage
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Feb 10, 2025
@workingjubilee
Rollup merge of rust-lang#136353 - purplesyringa:libtest-instant-wasm…
6ef2cd8 
…, r=Mark-Simulacrum

fix(libtest): Enable Instant on Emscripten targets

`Instant::now()` works correctly on Emscripten since rust-lang/libc#3962. All wasm-family targets with OS support can now handle instants.

Improves rust-lang#131738.

~~This changes the behavior of libtest on `unknown-unknown`/`unknown-none` wasm targets, but as far as I can see, libtest doesn't support them anyway. (Can anyone double-check?)~~ UPD: this patch no longer affects `unknown-unknown` targets.

``@rustbot`` label +A-libtest +T-testing-devex +O-emscripten +O-wasm -needs-triage
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 10, 2025
@rust-timer
Unrolled build for rust-lang#136353
231263d 
Rollup merge of rust-lang#136353 - purplesyringa:libtest-instant-wasm, r=Mark-Simulacrum

fix(libtest): Enable Instant on Emscripten targets

`Instant::now()` works correctly on Emscripten since rust-lang/libc#3962. All wasm-family targets with OS support can now handle instants.

Improves rust-lang#131738.

~~This changes the behavior of libtest on `unknown-unknown`/`unknown-none` wasm targets, but as far as I can see, libtest doesn't support them anyway. (Can anyone double-check?)~~ UPD: this patch no longer affects `unknown-unknown` targets.

``@rustbot`` label +A-libtest +T-testing-devex +O-emscripten +O-wasm -needs-triage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hoodmane @jieyouxu @rustbot