Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change-id warning shows up as clutter in CI logs #130352

Closed
RalfJung opened this issue Sep 14, 2024 · 2 comments · Fixed by #130356
Closed

change-id warning shows up as clutter in CI logs #130352

RalfJung opened this issue Sep 14, 2024 · 2 comments · Fixed by #130356
Assignees
Labels
A-CI Area: Our Github Actions CI T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@RalfJung
Copy link
Member

CI logs (specifically the mingw-check PR CI job) have a lot of this:

WARNING: The `change-id` is missing in the `config.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations.
NOTE: to silence this warning, add `change-id = 129473` at the top of `config.toml`
NOTE: this message was printed twice to make it more likely to be seen

This should probably be silenced on CI to avoid cluttering the logs?
Cc @onur-ozkan

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 14, 2024
@lolbinarycat lolbinarycat added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 14, 2024
@lolbinarycat lolbinarycat self-assigned this Sep 14, 2024
@lolbinarycat lolbinarycat removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 14, 2024
@fmease fmease added the A-CI Area: Our Github Actions CI label Sep 14, 2024
@onur-ozkan
Copy link
Member

Interesting... We have this already for ignoring change-tracker warnings:

rust/src/ci/run.sh

Lines 50 to 53 in e7386b3

# suppress change-tracker warnings on CI
if [ "$CI" != "" ]; then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set change-id=99999999"
fi

@Kobzol
Copy link
Contributor

Kobzol commented Sep 16, 2024

I think this somehow broke recently, the warnings were not there a few weeks ago, but now they're indeed spamming CI.

@bors bors closed this as completed in 1d0c7cf Oct 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 14, 2024
Rollup merge of rust-lang#130356 - lolbinarycat:ci-no-change-id, r=albertlarsan68

don't warn about a missing change-id in CI

fixes rust-lang#130352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants