-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LlvmArchiveBuilder
after a few months if no regression is found
#128955
Comments
In Android, we have a CI that builds AOSP with ToT clang toolchain and the latest Android Rust toolchain (currently 1.83). We use LTO for both clang and rust. If a C++ object is added to an
even though the build step is just packaging the object files and not merging the LLVM IR modules. The final link is performed by the lld from ToT llvm-project, which can correctly handle LLVM IR from different producers. @pcc added a change to LLVM ArchiveBuilder that only ignores this error when building a static lib: llvm/llvm-project#96848. It'd be great if ArArchiveBuilder also has the ability to ignore unknown bitcode when creating rlibs. (cc: @stephenhines @maurer) |
Opened #137017 to turn the error into a warning. |
…li-obk Don't error when adding a staticlib with bitcode files compiled by newer LLVM cc rust-lang#128955 (comment)
…li-obk Don't error when adding a staticlib with bitcode files compiled by newer LLVM cc rust-lang#128955 (comment)
…li-obk Don't error when adding a staticlib with bitcode files compiled by newer LLVM cc rust-lang#128955 (comment)
Rollup merge of rust-lang#137017 - bjorn3:ignore_invalid_bitcode, r=oli-obk Don't error when adding a staticlib with bitcode files compiled by newer LLVM cc rust-lang#128955 (comment)
Support reading thin archives in ArArchiveBuilder #128936 switches from using
LlvmArchiveBuilder
toArArchiveBuilder
.The text was updated successfully, but these errors were encountered: