-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[illumos] stack exhaustion doesn't print "thread has overflowed its stack" messages #128568
Comments
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Aug 2, 2024
rust/library/std/src/sys/pal/unix/stack_overflow.rs Lines 28 to 37 in f82eb4d
|
Thanks! Tried fixing it, but it's blocked on rust-lang/libc#3788 landing and making its way to rustc. |
jieyouxu
added
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
O-illumos
the other shiny OS
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Aug 4, 2024
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Sep 10, 2024
…trieb [illumos] enable SIGSEGV handler to detect stack overflows Use the same code as Solaris. I couldn't find any tests regarding this, but I did test a stage0 build against my stack-exhaust-test binary [1]. Before: ``` running with use_stacker = No, new_thread = false, make_large_local = false zsh: segmentation fault (core dumped) cargo run ``` After: ``` running with use_stacker = No, new_thread = false, make_large_local = false thread 'main' has overflowed its stack fatal runtime error: stack overflow zsh: IOT instruction (core dumped) cargo +stage0 run ``` Fixes rust-lang#128568. [1] https://github.com/sunshowers/stack-exhaust-test/
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Sep 10, 2024
…trieb [illumos] enable SIGSEGV handler to detect stack overflows Use the same code as Solaris. I couldn't find any tests regarding this, but I did test a stage0 build against my stack-exhaust-test binary [1]. Before: ``` running with use_stacker = No, new_thread = false, make_large_local = false zsh: segmentation fault (core dumped) cargo run ``` After: ``` running with use_stacker = No, new_thread = false, make_large_local = false thread 'main' has overflowed its stack fatal runtime error: stack overflow zsh: IOT instruction (core dumped) cargo +stage0 run ``` Fixes rust-lang#128568. [1] https://github.com/sunshowers/stack-exhaust-test/
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Sep 10, 2024
Rollup merge of rust-lang#130132 - sunshowers:illumos-sigsegv, r=Noratrieb [illumos] enable SIGSEGV handler to detect stack overflows Use the same code as Solaris. I couldn't find any tests regarding this, but I did test a stage0 build against my stack-exhaust-test binary [1]. Before: ``` running with use_stacker = No, new_thread = false, make_large_local = false zsh: segmentation fault (core dumped) cargo run ``` After: ``` running with use_stacker = No, new_thread = false, make_large_local = false thread 'main' has overflowed its stack fatal runtime error: stack overflow zsh: IOT instruction (core dumped) cargo +stage0 run ``` Fixes rust-lang#128568. [1] https://github.com/sunshowers/stack-exhaust-test/
shrirambalaji
pushed a commit
to shrirambalaji/rust
that referenced
this issue
Oct 6, 2024
Use the same code as Solaris. I couldn't find any tests regarding this, but I did test a stage0 build against my stack-exhaust-test binary [1]. Before: ``` running with use_stacker = No, new_thread = false, make_large_local = false zsh: segmentation fault (core dumped) cargo run ``` After: ``` running with use_stacker = No, new_thread = false, make_large_local = false thread 'main' has overflowed its stack fatal runtime error: stack overflow zsh: IOT instruction (core dumped) cargo +stage0 run ``` Fixes rust-lang#128568. [1] https://github.com/sunshowers/stack-exhaust-test/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried this code:
Also reproducible with this example program: https://github.com/sunshowers/stack-exhaust-test, by running
cargo run
.I expected to see this happen: Similar to Linux:
Instead, this happened:
Meta
rustc --version --verbose
:Also reproduces with:
Backtrace
(there's no backtrace, which I believe is expected in this situation)
The text was updated successfully, but these errors were encountered: