`core::fmt::rt::Opaque` not `Sync` caused future compile fail on nightly-2024-03-09 #122674

PureWhiteWu · 2024-03-18T05:06:47Z

Code

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=33a2a5c86f6e3276da4da323ac28ed31

Version with regression

searched nightlies: from nightly-2024-03-07 to nightly-2024-03-10
regressed nightly: nightly-2024-03-09
searched commit range: 9c3ad80...46b180e
regressed commit: a655e64

bisected with cargo-bisect-rustc v0.6.8

Host triple: aarch64-apple-darwin
Reproduce with:

cargo bisect-rustc --start 2024-03-08 --end 2024-03-09

@rustbot modify labels: +regression-from-stable-to-nightly -regression-untriaged

The text was updated successfully, but these errors were encountered:

PureWhiteWu · 2024-03-18T06:54:39Z

I suspect #121563 caused this regression, but I don't know how to use cargo-bisect-rustc to test this pr(I tried some times but all failed).

Do you have any ideas about this? @Jarcho

Noratrieb · 2024-03-18T07:04:14Z

if you use the latest version of cargo-bisect-rustc it will bisect the roll-up for you.

PureWhiteWu · 2024-03-18T07:08:49Z

@Nilstrieb Hi, I'm using the latest version of cargo-bisect-rustc, but seems that it fails to bisect the roll-up.

Here's the complete log:

looking for regression commit between 2024-03-08 and 2024-03-09
fetching (via remote github) commits from max(9c3ad802d9b9633d60d3a74668eb1be819212d34, 2024-03-06) to 46b180ec2452d388c5d9c14009442e2e0beb01d7
ending github query because we found starting sha: 9c3ad802d9b9633d60d3a74668eb1be819212d34
get_commits_between returning commits, len: 10
  commit[0] 2024-03-07: Auto merge of #119199 - dpaoliello:arm64ec, r=petrochenkov
  commit[1] 2024-03-07: Auto merge of #122151 - GuillaumeGomez:rollup-hfxr9kv, r=GuillaumeGomez
  commit[2] 2024-03-08: Auto merge of #122048 - erikdesjardins:inbounds, r=oli-obk
  commit[3] 2024-03-08: Auto merge of #122059 - nyurik:with-as-const-str, r=cuviper
  commit[4] 2024-03-08: Auto merge of #120268 - DianQK:otherwise_is_last_variant_switchs, r=oli-obk
  commit[5] 2024-03-08: Auto merge of #122182 - matthiaskrgr:rollup-gzimi4c, r=matthiaskrgr
  commit[6] 2024-03-08: Auto merge of #122078 - gurry:121443-ice-layout-is-sized-alt, r=oli-obk
  commit[7] 2024-03-08: Auto merge of #121500 - oli-obk:track_errors12, r=petrochenkov
  commit[8] 2024-03-08: Auto merge of #122190 - matthiaskrgr:rollup-9ol4y30, r=matthiaskrgr
  commit[9] 2024-03-08: Auto merge of #122206 - matthiaskrgr:rollup-4txx9wx, r=matthiaskrgr
validated commits found, specifying toolchains

checking the start range to verify it passes
installing 9c3ad802d9b9633d60d3a74668eb1be819212d34
rust-std-nightly-aarch64-apple-darwin: 25.41 MB / 25.41 MB [============================================================================================================================================================] 100.00 % 16.06 MB/s testing...
RESULT: 9c3ad802d9b9633d60d3a74668eb1be819212d34, ===> No
uninstalling 9c3ad802d9b9633d60d3a74668eb1be819212d34

checking the end range to verify it does not pass
installing 46b180ec2452d388c5d9c14009442e2e0beb01d7
rust-std-nightly-aarch64-apple-darwin: 25.39 MB / 25.39 MB [============================================================================================================================================================] 100.00 % 17.43 MB/s testing...
RESULT: 46b180ec2452d388c5d9c14009442e2e0beb01d7, ===> Yes
uninstalling 46b180ec2452d388c5d9c14009442e2e0beb01d7

5 versions remaining to test after this (roughly 3 steps)
installing 14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f
rust-std-nightly-aarch64-apple-darwin: 25.44 MB / 25.44 MB [============================================================================================================================================================] 100.00 % 19.68 MB/s testing...
RESULT: 14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f, ===> No
uninstalling 14fbc3c00525b41a3a3ee2c90e9ab6fd3b05274f

3 versions remaining to test after this (roughly 2 steps)
installing 42825768b103c28b10ce0407749acb21d32abeec
rust-std-nightly-aarch64-apple-darwin: 25.42 MB / 25.42 MB [============================================================================================================================================================] 100.00 % 18.31 MB/s testing...
RESULT: 42825768b103c28b10ce0407749acb21d32abeec, ===> No
uninstalling 42825768b103c28b10ce0407749acb21d32abeec

2 versions remaining to test after this (roughly 2 steps)
installing 74acabe9b042ea8c42862ee29aca2a8b7d333644
rust-std-nightly-aarch64-apple-darwin: 25.39 MB / 25.39 MB [============================================================================================================================================================] 100.00 % 19.89 MB/s testing...
RESULT: 74acabe9b042ea8c42862ee29aca2a8b7d333644, ===> No
uninstalling 74acabe9b042ea8c42862ee29aca2a8b7d333644

1 versions remaining to test after this (roughly 1 steps)
installing a655e648a9f94d74263108366b83e677af56e35d
rust-std-nightly-aarch64-apple-darwin: 25.41 MB / 25.41 MB [============================================================================================================================================================] 100.00 % 15.75 MB/s testing...
RESULT: a655e648a9f94d74263108366b83e677af56e35d, ===> Yes
uninstalling a655e648a9f94d74263108366b83e677af56e35d

searched toolchains 9c3ad802d9b9633d60d3a74668eb1be819212d34 through 46b180ec2452d388c5d9c14009442e2e0beb01d7


********************************************************************************
Regression in a655e648a9f94d74263108366b83e677af56e35d
********************************************************************************

Attempting to search unrolled perf builds
Found commits ["3e513c4c", "2d1c3361", "d2049e2a", "079e6df4", "1f4c0e1b", "de1b1944", "fd318cd5", "2ea39767"]
installing 3e513c4c2c66ab0c2fd138e3a53e4873277964f1
uninstalling 3e513c4c2c66ab0c2fd138e3a53e4873277964f1
installing 2d1c3361fe0fff25d8d5a8f02f9f94d8aa56e566
uninstalling 2d1c3361fe0fff25d8d5a8f02f9f94d8aa56e566
installing d2049e2a53ae398bba7a7e3f5c9519a721d07f0f
uninstalling d2049e2a53ae398bba7a7e3f5c9519a721d07f0f
installing 079e6df43c77f89c3d6d71bf563be219286904b5
uninstalling 079e6df43c77f89c3d6d71bf563be219286904b5
installing 1f4c0e1bed6ba336e5ee19076246c53f9f33e6df
uninstalling 1f4c0e1bed6ba336e5ee19076246c53f9f33e6df
installing de1b1944b3846544b36a05ac21b4a9520bf938ec
uninstalling de1b1944b3846544b36a05ac21b4a9520bf938ec
installing fd318cd5b1d3b39f6412149d5dceb8099683aefe
uninstalling fd318cd5b1d3b39f6412149d5dceb8099683aefe
installing 2ea39767a9dce310c992f55b5bd7dfac6bf531dd
uninstalling 2ea39767a9dce310c992f55b5bd7dfac6bf531dd
ERROR: none of the toolchains satisfied the predicate
==================================================================================
= Please file this regression report on the rust-lang/rust GitHub repository     =
=        New issue: https://github.com/rust-lang/rust/issues/new                 =
=     Known issues: https://github.com/rust-lang/rust/issues                     =
= Copy and paste the text below into the issue report thread.  Thanks!           =
==================================================================================

searched nightlies: from nightly-2024-03-08 to nightly-2024-03-09
regressed nightly: nightly-2024-03-09
searched commit range: https://github.com/rust-lang/rust/compare/9c3ad802d9b9633d60d3a74668eb1be819212d34...46b180ec2452d388c5d9c14009442e2e0beb01d7
regressed commit: https://github.com/rust-lang/rust/commit/a655e648a9f94d74263108366b83e677af56e35d

<details>
<summary>bisected with <a href='https://github.com/rust-lang/cargo-bisect-rustc'>cargo-bisect-rustc</a> v0.6.8</summary>


Host triple: aarch64-apple-darwin
Reproduce with:
```bash
cargo bisect-rustc --start 2024-03-08 --end 2024-03-09
\```
</details>

lqd · 2024-03-18T08:12:34Z

It does bisect to #121563 for me. (With this visitor change in particular e760c44#diff-8b601779832d29e42b24bb88ccc3a5762217d72f148e8070767ee787b271190c)

…errors Do not eat nested expressions' results in `MayContainYieldPoint` format args visitor rust-lang#121563 unintentionally changed the `MayContainYieldPoint` format args visitor behavior, now missing yield points in nested expressions, as seen in rust-lang#122674. The walk can find a yield point in an expression but it was ignored. r? `@petrochenkov` as the reviewer of rust-lang#121563 cc `@Jarcho` as the author Fixes rust-lang#122674. We're in the 1.77 release week. rust-lang#121563 will land on 1.78 but beta is still 1.77.9: this PR will likely need to be backported soon after beta is cut.

Rollup merge of rust-lang#122680 - lqd:nested-await-args, r=compiler-errors Do not eat nested expressions' results in `MayContainYieldPoint` format args visitor rust-lang#121563 unintentionally changed the `MayContainYieldPoint` format args visitor behavior, now missing yield points in nested expressions, as seen in rust-lang#122674. The walk can find a yield point in an expression but it was ignored. r? ``@petrochenkov`` as the reviewer of rust-lang#121563 cc ``@Jarcho`` as the author Fixes rust-lang#122674. We're in the 1.77 release week. rust-lang#121563 will land on 1.78 but beta is still 1.77.9: this PR will likely need to be backported soon after beta is cut.

lqd · 2024-03-18T20:02:04Z

The fix has landed on master. Reopening to track beta backport.

PureWhiteWu · 2024-03-24T14:01:17Z

@lqd Hi, 1.77.0 has been released, can this be backported to beta now?

lqd · 2024-03-24T15:16:28Z

I wasn’t at the weekly meeting and I don’t know for sure: #122680 is not yet marked as accepted for backport (it may just be an oversight in labeling, I’ll try to find out). Once that is done though, the release team, I believe, will backport it.

apiraino · 2024-03-24T22:28:41Z

updated labels on #122680 (sorry for the delay)

cuviper · 2024-04-12T17:15:49Z

That was backported in #123172.

PureWhiteWu added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Mar 18, 2024

Noratrieb added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 18, 2024

lqd mentioned this issue Mar 18, 2024

Do not eat nested expressions' results in MayContainYieldPoint format args visitor #122680

Merged

lqd added this to the 1.78.0 milestone Mar 18, 2024

bors closed this as completed in 72e2c7c Mar 18, 2024

lqd reopened this Mar 18, 2024

cuviper closed this as completed Apr 12, 2024

apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 15, 2024

y21 mentioned this issue Jul 19, 2024

Use ControlFlow in more places rust-lang/rust-clippy#12830

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`core::fmt::rt::Opaque` not `Sync` caused future compile fail on nightly-2024-03-09 #122674

`core::fmt::rt::Opaque` not `Sync` caused future compile fail on nightly-2024-03-09 #122674

PureWhiteWu commented Mar 18, 2024 •

edited

Loading

PureWhiteWu commented Mar 18, 2024

Noratrieb commented Mar 18, 2024

PureWhiteWu commented Mar 18, 2024 •

edited

Loading

lqd commented Mar 18, 2024 •

edited

Loading

lqd commented Mar 18, 2024

PureWhiteWu commented Mar 24, 2024

lqd commented Mar 24, 2024

apiraino commented Mar 24, 2024

cuviper commented Apr 12, 2024

core::fmt::rt::Opaque not Sync caused future compile fail on nightly-2024-03-09 #122674

core::fmt::rt::Opaque not Sync caused future compile fail on nightly-2024-03-09 #122674

Comments

PureWhiteWu commented Mar 18, 2024 • edited Loading

Code

Version with regression

PureWhiteWu commented Mar 18, 2024

Noratrieb commented Mar 18, 2024

PureWhiteWu commented Mar 18, 2024 • edited Loading

lqd commented Mar 18, 2024 • edited Loading

lqd commented Mar 18, 2024

PureWhiteWu commented Mar 24, 2024

lqd commented Mar 24, 2024

apiraino commented Mar 24, 2024

cuviper commented Apr 12, 2024

`core::fmt::rt::Opaque` not `Sync` caused future compile fail on nightly-2024-03-09 #122674

`core::fmt::rt::Opaque` not `Sync` caused future compile fail on nightly-2024-03-09 #122674

PureWhiteWu commented Mar 18, 2024 •

edited

Loading

PureWhiteWu commented Mar 18, 2024 •

edited

Loading

lqd commented Mar 18, 2024 •

edited

Loading