Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for Bevy special-casing of implied bounds and -Zno-implied-bounds-compat #119956

Open
jackh726 opened this issue Jan 14, 2024 · 0 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC P-high High priority T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@jackh726
Copy link
Member

jackh726 commented Jan 14, 2024

In #118553 we're adding special casing for functions containing a type using ParamSet from Bevy to not emit an error or warning for incorrect implied bounds (see #109628). This special casing can be disabled via the unstable -Zno-implied-bounds-compat flag.

The expectation is that we may be adding additional implied bounds that (with some modifications to Bevy) allows Bevy's dependents to continue compiling without errors or warnings. When those changes are made, we want to remove this special casing. Alternatively, if we find out we can't add additional implied bounds in a way that allows dependents to continue compiling, we still want to remove the special casing.

@jackh726 jackh726 added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-types Relevant to the types team, which will review and decide on the PR/issue. labels Jan 14, 2024
@jackh726 jackh726 changed the title Tracking Issue for Bevy special-casing of implied bounds Tracking Issue for Bevy special-casing of implied bounds and -Z no-implied-bounds-compat Jan 17, 2024
@lcnr lcnr changed the title Tracking Issue for Bevy special-casing of implied bounds and -Z no-implied-bounds-compat Tracking Issue for Bevy special-casing of implied bounds and -Zno-implied-bounds-compat Jan 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 18, 2024
error on incorrect implied bounds in wfcheck except for Bevy dependents

Rebase of rust-lang#109763

Additionally, special cases Bevy `ParamSet` types to not trigger the lint. This is tracked in rust-lang#119956.

Fixes rust-lang#109628
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 19, 2024
use implied bounds compat mode in MIR borrowck

cc
- rust-lang#119956
- rust-lang#118553

This should hopefully fix bevy 🤔 `cargo test` ends up freezing my computer though, cargo build went from err to ok however 😁

r? `@jackh726`
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 19, 2024
use implied bounds compat mode in MIR borrowck

cc
- rust-lang#119956
- rust-lang#118553

This should hopefully fix bevy 🤔 `cargo test` ends up freezing my computer though, cargo build went from err to ok however 😁

r? `@jackh726`
@lcnr lcnr added the P-high High priority label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC P-high High priority T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants