Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note on incorrect trailing semicolon #1195

Closed
brson opened this issue Nov 19, 2011 · 1 comment
Closed

Add a note on incorrect trailing semicolon #1195

brson opened this issue Nov 19, 2011 · 1 comment
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.4

Comments

@brson
Copy link
Contributor

brson commented Nov 19, 2011

Putting a trailing semi on statements that should be expressions is a common error:

ret if x { true; } else { false; };

It shouldn't be too difficult to look at the types here and offer a suggestion of what the problem might be
@lht lht mentioned this issue Jan 31, 2012
Closed
@catamorphism
Copy link
Contributor

I believe this is a dup of #1481. If it's not asking for the same thing, reopen.

celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @adpaco-aws @zhassan-aws
Enable fat pointer comparison for slices and add check for vtable ones (
25dfce5 
rust-lang#1195)

* Implement pointer comparison for fat pointers

1. This only works for pointers with the same provenance.
2. We should model vtable comparison a bit differently. Follow up commit

* Use integer comparison for vtable.

* Add check for unstable vtable pointer comparison

* Address the following PR comments

    - Rename variables.
    - Add location to the assertion and other statements.
    - Added a link to the compiler PR that implemented fat pointer
      comparison.

Co-authored-by: Adrian Palacios <[email protected]>
Co-authored-by: Zyad Hassan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@brson @catamorphism