Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate feeding def_span in the resolver #118552

Open
cjgillot opened this issue Dec 2, 2023 · 0 comments
Open

Investigate feeding def_span in the resolver #118552

cjgillot opened this issue Dec 2, 2023 · 0 comments
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@cjgillot
Copy link
Contributor

cjgillot commented Dec 2, 2023

This is the same idea as #118188 but for the def_span queries.

At each place where #118188 added a call to tcx.feed_local_def_id(..).def_kind, we need to add a call to def_span. The parameter to this call should mimick the implementation of def_span in rustc_middle::hir::map.

Please contact me on zulip for questions.
@cjgillot cjgillot added E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Dec 2, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 2, 2023
@cjgillot cjgillot mentioned this issue Dec 2, 2023
Merged
@fmease fmease added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 2, 2023
@bvanjoi bvanjoi mentioned this issue Dec 5, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2023
@bors
Auto merge of rust-lang#118633 - bvanjoi:fix-118552, r=<try>
167da5e 
feed `def_span` in resolver

Fixes rust-lang#118552

This PR removes `provider.def_span` and instead introduces it during the definition collection process

r? `@cjgillot`
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 7, 2023
@bors
Auto merge of rust-lang#118633 - bvanjoi:fix-118552, r=<try>
e344b7c 
feed `def_span` in resolver

Fixes rust-lang#118552

This PR removes `provider.def_span` and instead introduces it during the definition collection process

r? `@cjgillot`
@oli-obk oli-obk moved this to Todo in query feeding May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
query feeding
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feed def_span in resolver bvanjoi/rust
3 participants
@cjgillot @fmease @rustbot