Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying external libraries by filename #11802

Closed
ghost opened this issue Jan 25, 2014 · 7 comments
Closed

Add support for specifying external libraries by filename #11802

ghost opened this issue Jan 25, 2014 · 7 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries C-feature-request Category: A feature request, i.e: not implemented / a PR. P-medium Medium priority T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@ghost
Copy link

ghost commented Jan 25, 2014

Some libraries have multiple filenames:

set(ZLIB_NAMES z zlib zdll zlib1 zlibd zlibd1)

There is currently no way to tell rustc that #[link(name = "z")] should be satisfied by zlib1.dll.
@metajack
Copy link
Contributor

Brian and I discussed this last week in the context of glfw-rs (the glfw lib is called glfw3 on some distros of Linux and glfw on others). Brian suggested that there be some way to specify a mapping from link names to actual libraries.

cc @bjz

@metajack
Copy link
Contributor

nominating

@pnkfelix
Copy link
Member

Not accepted for 1.0, but important nonetheless so P-high.

This was referenced Apr 25, 2014
Closed
Closed
@steveklabnik steveklabnik added A-attributes Area: Attributes (`#[…]`, `#![…]`) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Apr 20, 2015
@steveklabnik
Copy link
Member

triage: nothing has changed with link in a while.

@steveklabnik
Copy link
Member

Triage: no change here. That said, I would expect that maybe this is something that should be going through Cargo and build scripts, rather than modifying link?

@nagisa
Copy link
Member

nagisa commented Jun 1, 2017

This seems fairly close to being closed. The need is satisfied by the build scripts, which is the generally accepted way to do complex linking decisions.

@nagisa nagisa added T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 1, 2017
@Mark-Simulacrum Mark-Simulacrum added A-linkage Area: linking into static, shared libraries and binaries C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed A-attributes Area: Attributes (`#[…]`, `#![…]`) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jul 28, 2017
@Dylan-DPC-zz
Copy link

Closing this as it can be done by build scripts. Thanks

flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 16, 2023
@bors
Auto merge of rust-lang#11802 - dswij:issue-11765, r=xFrednet
7ad3373 
`needless_return_with_question_mark` ignore let-else

Fixes rust-lang#11765

This PR makes `needless_return_with_question_mark` to ignore expr inside let-else.

changelog: [`needless_return_with_question_mark`] ignore let-else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries C-feature-request Category: A feature request, i.e: not implemented / a PR. P-medium Medium priority T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@steveklabnik @metajack @pnkfelix @nagisa @Mark-Simulacrum @Dylan-DPC-zz