-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest updating the compiler #117318
Comments
Wouldn't that require that |
That's why the message should be a suggestion with "if you're on an older compiler". We cannot know what's stable in the future, but making the suggestion doesn't hurt and seems like a good idea. |
It might be worth checking the system time and only printing this message if the current version was built more than (say) six weeks ago. That's enough time for one release train to arrive. |
@rustbot claim |
… feature Part of Issue rust-lang#117318
… feature Part of Issue rust-lang#117318
Hi all, this issue seems to have stalled? I hope no one minds if I make an attempt. I'll claim this and open a PR shortly |
@rustbot claim |
…g-compiler, r=Nilstrieb Suggest Upgrading Compiler for Gated Features This PR addresses rust-lang#117318 I have a few questions: 1. Do we want to specify the current version and release date of the compiler? I have added this in via environment variables, which I found in the code for the rustc cli where it handles the `--version` flag a. How can I handle the changing message in the tests? 3. Do we want to only show this message when the compiler is old? a. How can we determine when the compiler is old? I'll wait until we figure out the message to bless the tests
…g-compiler, r=Nilstrieb Suggest Upgrading Compiler for Gated Features This PR addresses rust-lang#117318 I have a few questions: 1. Do we want to specify the current version and release date of the compiler? I have added this in via environment variables, which I found in the code for the rustc cli where it handles the `--version` flag a. How can I handle the changing message in the tests? 3. Do we want to only show this message when the compiler is old? a. How can we determine when the compiler is old? I'll wait until we figure out the message to bless the tests
…ing-compiler, r=Nilstrieb Suggest Upgrading Compiler for Gated Features This PR addresses rust-lang#117318 I have a few questions: 1. Do we want to specify the current version and release date of the compiler? I have added this in via environment variables, which I found in the code for the rustc cli where it handles the `--version` flag a. How can I handle the changing message in the tests? 3. Do we want to only show this message when the compiler is old? a. How can we determine when the compiler is old? I'll wait until we figure out the message to bless the tests
…ing-compiler, r=Nilstrieb Suggest Upgrading Compiler for Gated Features This PR addresses rust-lang#117318 I have a few questions: 1. Do we want to specify the current version and release date of the compiler? I have added this in via environment variables, which I found in the code for the rustc cli where it handles the `--version` flag a. How can I handle the changing message in the tests? 3. Do we want to only show this message when the compiler is old? a. How can we determine when the compiler is old? I'll wait until we figure out the message to bless the tests
…g-compiler, r=Nilstrieb Suggest Upgrading Compiler for Gated Features This PR addresses rust-lang#117318 I have a few questions: 1. Do we want to specify the current version and release date of the compiler? I have added this in via environment variables, which I found in the code for the rustc cli where it handles the `--version` flag a. How can I handle the changing message in the tests? 3. Do we want to only show this message when the compiler is old? a. How can we determine when the compiler is old? I'll wait until we figure out the message to bless the tests
Considering #119088 landed, I think this could be closed? :) |
Agreed. |
Code
On an older compiler:
Current output
Desired output
Rationale and extra context
Throughout all my time with Rust I've heard from multiple people (who may be less experienced) on various occasions that after pulling the latest commit, that my Rust code is accidentally using unstable features. Every single time they didn't know that the problem isn't that I used unstable features, but that those features stabilized in the meantime and that they need to update their compiler version.
Maybe the compiler could even check based on the date if a new version of the compiler should be out and only emit that note then.
Other cases
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: