-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pub mod b{use b::*;pub mod b;} compile failure #10980
Labels
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
Comments
cc @pcwalton, the backtrace looks like this:
|
Minimal test case: #[feature(globs)];
mod a {
use a::*;
} |
More minimal: #[feature(globs)];
use self::*; |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Jun 30, 2023
…ns, r=dswij Fix `find_format_arg_expr` when incremental compilation is enabled Fixes rust-lang#10969 [`lower_span`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_ast_lowering/struct.LoweringContext.html#method.lower_span) gives AST spans a [parent](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_span/struct.SpanData.html#structfield.parent) when lowering to the HIR. That meant the `==` span comparison would return false even though the spans are pointing to the same thing. We now ignore the parent when comparing the spans Debugging this was quite the puzzle, because the parent is not included in the debug output of `Span`s or `SpanData` 😬 changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Sep 25, 2023
…=dswij Ignore span's parents in `collect_ast_format_args`/`find_format_args` Fixes rust-lang#11470, covers some cases missed by rust-lang#10980 Can't have a test yet because of rust-lang#11126 but it works locally changelog: none r? `@dswij`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
English is not my native language :(
The text was updated successfully, but these errors were encountered: