-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we keep un-deriving traits in library
to make them const
?
#102371
Comments
Can we get input from @rust-lang/wg-const-eval (not sure this is the right group) on the general trajectory for const impls? It was my recollection that we wanted to potentially back out the const-ification of std's traits until we had a more solid plan on that feature -- |
@fee1-dead has a PR for #[derive_const] #102049 |
We discussed this in the libs meeting, and agreed that yes, we should not start changing from derives to hand-written impls everywhere just for const. #102049 looks like a good way forward for now. |
…oli-obk Add the `#[derive_const]` attribute Closes rust-lang#102371. This is a minimal patchset for the attribute to work. There are no restrictions on what traits this attribute applies to. r? ``@oli-obk``
…oli-obk Add the `#[derive_const]` attribute Closes rust-lang#102371. This is a minimal patchset for the attribute to work. There are no restrictions on what traits this attribute applies to. r? ```@oli-obk```
…oli-obk Add the `#[derive_const]` attribute Closes rust-lang#102371. This is a minimal patchset for the attribute to work. There are no restrictions on what traits this attribute applies to. r? ````@oli-obk````
PRs like https://github.com/rust-lang/rust/pull/101698/files#diff-0752889661748b8a15a597d7156127b6fb90fdeda0627be50e07f3f785bd0f4dR678 stop using derives for traits because the derives can't make things
const
.Should we maybe stop doing this in
library
until there's a way to#[const_derive(Ord)]
or similar? It looks like we're on track to stop deriving essentially anything, which seems like a bad worldstate.The text was updated successfully, but these errors were encountered: