correct lint case

rust-lang · Jan 26, 2024 · f58950d · f58950d
1 parent 57dd25e
commit f58950d
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/tests/ui/needless_return_with_question_mark.fixed b/tests/ui/needless_return_with_question_mark.fixed
@@ -104,3 +104,21 @@ fn issue11982() {
         Ok(())
     }
 }
+
+fn issue11982_no_conversion() {
+    mod bar {
+        pub struct Error;
+        pub fn foo(_: bool) -> Result<(), Error> {
+            Ok(())
+        }
+    }
+
+    fn foo(ok: bool) -> Result<(), bar::Error> {
+        if !ok {
+            bar::foo(ok).map(|_| Ok::<(), bar::Error>(()))?;
+            //~^ ERROR: unneeded `return` statement with `?` operator
+        };
+        Ok(())
+    }
+
+}
diff --git a/tests/ui/needless_return_with_question_mark.rs b/tests/ui/needless_return_with_question_mark.rs
@@ -104,3 +104,20 @@ fn issue11982() {
         Ok(())
     }
 }
+
+fn issue11982_no_conversion() {
+    mod bar {
+        pub struct Error;
+        pub fn foo(_: bool) -> Result<(), Error> {
+            Ok(())
+        }
+    }
+
+    fn foo(ok: bool) -> Result<(), bar::Error> {
+        if !ok {
+            return bar::foo(ok).map(|_| Ok::<(), bar::Error>(()))?;
+            //~^ ERROR: unneeded `return` statement with `?` operator
+        };
+        Ok(())
+    }
+}
diff --git a/tests/ui/needless_return_with_question_mark.stderr b/tests/ui/needless_return_with_question_mark.stderr
@@ -13,5 +13,11 @@ error: unneeded `return` statement with `?` operator
 LL |         return Err(())?;
    |         ^^^^^^^ help: remove it
 
-error: aborting due to 2 previous errors
+error: unneeded `return` statement with `?` operator
+  --> $DIR/needless_return_with_question_mark.rs:118:13
+   |
+LL |             return bar::foo(ok).map(|_| Ok::<(), bar::Error>(()))?;
+   |             ^^^^^^^ help: remove it
+
+error: aborting due to 3 previous errors