-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
relax priv-in-pub lint on generic bounds and where clauses in trait i…
…mpls
- Loading branch information
Showing
9 changed files
with
325 additions
and
82 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 2 additions & 33 deletions
35
src/test/ui/const-generics/generic_const_exprs/eval-privacy.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,12 @@ | ||
| warning: private type `fn(u8) -> u8 {my_const_fn}` in public interface (error E0446) | ||
| --> $DIR/eval-privacy.rs:12:1 | ||
| | | ||
| LL | / impl<const U: u8> Trait for Const<U> | ||
| LL | | | ||
| LL | | | ||
| LL | | | ||
| ... | | ||
| LL | | } | ||
| LL | | } | ||
| | |_^ | ||
| | | ||
| = note: `#[warn(private_in_public)]` on by default | ||
| = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537> | ||
|
|
||
| warning: private type `fn(u8) -> u8 {my_const_fn}` in public interface (error E0446) | ||
| --> $DIR/eval-privacy.rs:12:1 | ||
| | | ||
| LL | / impl<const U: u8> Trait for Const<U> | ||
| LL | | | ||
| LL | | | ||
| LL | | | ||
| ... | | ||
| LL | | } | ||
| LL | | } | ||
| | |_^ | ||
| | | ||
| = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537> | ||
|
|
||
| error[E0446]: private type `fn(u8) -> u8 {my_const_fn}` in public interface | ||
| --> $DIR/eval-privacy.rs:21:5 | ||
| --> $DIR/eval-privacy.rs:16:5 | ||
| | | ||
| LL | type AssocTy = Const<{ my_const_fn(U) }>; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type | ||
| ... | ||
| LL | const fn my_const_fn(val: u8) -> u8 { | ||
| | ----------------------------------- `fn(u8) -> u8 {my_const_fn}` declared as private | ||
|
|
||
| error: aborting due to previous error; 2 warnings emitted | ||
| error: aborting due to previous error | ||
|
|
||
| For more information about this error, try `rustc --explain E0446`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // priv-in-pub lint tests where the private type appears in the | ||
| // `where` clause of a public item | ||
|
|
||
| #![crate_type = "lib"] | ||
| #![feature(generic_const_exprs)] | ||
| #![allow(incomplete_features)] | ||
|
|
||
|
|
||
| struct PrivTy; | ||
| trait PrivTr {} | ||
| pub struct PubTy; | ||
| pub struct PubTyGeneric<T>(T); | ||
| pub trait PubTr {} | ||
| impl PubTr for PrivTy {} | ||
| pub trait PubTrWithAssocTy { type AssocTy; } | ||
| impl PubTrWithAssocTy for PrivTy { type AssocTy = PrivTy; } | ||
|
|
||
|
|
||
| pub struct S | ||
| //~^ WARNING private type `PrivTy` in public interface | ||
| //~| WARNING hard error | ||
| where | ||
| PrivTy: | ||
| {} | ||
|
|
||
|
|
||
| pub enum E | ||
| //~^ WARNING private type `PrivTy` in public interface | ||
| //~| WARNING hard error | ||
| where | ||
| PrivTy: | ||
| {} | ||
|
|
||
|
|
||
| pub fn f() | ||
| //~^ WARNING private type `PrivTy` in public interface | ||
| //~| WARNING hard error | ||
| where | ||
| PrivTy: | ||
| {} | ||
|
|
||
|
|
||
| impl S | ||
| //~^ ERROR private type `PrivTy` in public interface | ||
| where | ||
| PrivTy: | ||
| { | ||
| pub fn f() | ||
| //~^ WARNING private type `PrivTy` in public interface | ||
| //~| WARNING hard error | ||
| where | ||
| PrivTy: | ||
| {} | ||
| } | ||
|
|
||
|
|
||
| impl PubTr for PubTy | ||
| where | ||
| PrivTy: | ||
| {} | ||
|
|
||
|
|
||
| impl<T> PubTr for PubTyGeneric<T> | ||
| where | ||
| T: PubTrWithAssocTy<AssocTy=PrivTy> | ||
| {} | ||
|
|
||
|
|
||
| pub struct Const<const U: u8>; | ||
|
|
||
| pub trait Trait { | ||
| type AssocTy; | ||
| fn assoc_fn() -> Self::AssocTy; | ||
| } | ||
|
|
||
| impl<const U: u8> Trait for Const<U> | ||
| where | ||
| Const<{ my_const_fn(U) }>: , | ||
| { | ||
| type AssocTy = Const<{ my_const_fn(U) }>; | ||
| //~^ ERROR private type | ||
| fn assoc_fn() -> Self::AssocTy { | ||
| Const | ||
| } | ||
| } | ||
|
|
||
| const fn my_const_fn(val: u8) -> u8 { | ||
| // body of this function doesn't matter | ||
| val | ||
| } |
Oops, something went wrong.