Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Although in the example function `each` works as expected with rust-0.6 (the latest release), it fails to even compile with `incoming` rust (see test/compile-fail/bad-for-loop-2.rs). Change the function to return a `bool` instead of `()`: this works fine with both versions of rust, and does not misguide potential contributors. Signed-off-by: Ramkumar Ramachandra <[email protected]>
- Loading branch information
dd923e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from bstrie
at https://github.com/artagnon/rust/commit/dd923e3831f93c7ad8f3b872069fdeff31e522c7
dd923e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging artagnon/rust/bad-for-loop = dd923e3 into auto
dd923e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
artagnon/rust/bad-for-loop = dd923e3 merged ok, testing candidate = 8450dc8
dd923e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
http://buildbot.rust-lang.org/builders/auto-linux/builds/1581
http://buildbot.rust-lang.org/builders/auto-win/builds/1576
http://buildbot.rust-lang.org/builders/auto-mac/builds/1595
dd923e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding incoming to auto = 8450dc8