Hoist only-executables check above producing crate ident

rust-lang · Mar 1, 2024 · d363db7 · d363db7
1 parent bf8756d
commit d363db7
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/compiler/rustc_lint/src/nonstandard_style.rs b/compiler/rustc_lint/src/nonstandard_style.rs
@@ -332,6 +332,10 @@ impl<'tcx> LateLintPass<'tcx> for NonSnakeCase {
             return;
         }
 
+        if cx.tcx.crate_types().iter().all(|&crate_type| crate_type == CrateType::Executable) {
+            return;
+        }
+
         let crate_ident = if let Some(name) = &cx.tcx.sess.opts.crate_name {
             Some(Ident::from_str(name))
         } else {
@@ -367,9 +371,7 @@ impl<'tcx> LateLintPass<'tcx> for NonSnakeCase {
                 })
         };
 
-        if let Some(ident) = &crate_ident
-            && cx.tcx.crate_types().iter().all(|&crate_type| crate_type != CrateType::Executable)
-        {
+        if let Some(ident) = &crate_ident {
             self.check_snake_case(cx, "crate", ident);
         }
     }