Skip to content

Commit

Permalink
Disable ARM ehabi when building without landing pads
Browse files Browse the repository at this point in the history
  • Loading branch information
bharrisau committed Feb 2, 2014
1 parent dce61c9 commit abc8372
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/librustc/back/link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,13 @@ pub mod write {
llvm_c_strs.push(s);
};
add("rustc"); // fake program name
add("-arm-enable-ehabi");
add("-arm-enable-ehabi-descriptors");

// Only enable ARM EHABI if we are unwinding
if !sess.no_landing_pads() {
add("-arm-enable-ehabi");
add("-arm-enable-ehabi-descriptors");
}

if vectorize_loop { add("-vectorize-loops"); }
if vectorize_slp { add("-vectorize-slp"); }
if sess.time_llvm_passes() { add("-time-passes"); }
Expand Down

5 comments on commit abc8372

@bors
Copy link
Contributor

@bors bors commented on abc8372 Feb 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at bharrisau@abc8372

@bors
Copy link
Contributor

@bors bors commented on abc8372 Feb 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging bharrisau/rust/arm-no-landing = abc8372 into auto

@bors
Copy link
Contributor

@bors bors commented on abc8372 Feb 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bharrisau/rust/arm-no-landing = abc8372 merged ok, testing candidate = 87c3ab15

@bors
Copy link
Contributor

@bors bors commented on abc8372 Feb 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharrisau
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails the android target on the no-landing-pads test trying to unwind the stack. I'll have a look through LLVM and see what is up.

Please sign in to comment.