Skip to content

Commit

Permalink
Also treat impl definition parent as transparent regarding modules
Browse files Browse the repository at this point in the history
  • Loading branch information
Urgau committed Nov 1, 2024
1 parent a0d98ff commit 6ae4697
Show file tree
Hide file tree
Showing 2 changed files with 62 additions and 2 deletions.
10 changes: 8 additions & 2 deletions compiler/rustc_lint/src/non_local_def.rs
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,15 @@ impl<'tcx> LateLintPass<'tcx> for NonLocalDefinitions {
// };
// };
// ```
//
// It isn't possible to mix a impl in a module with const-anon, but an item can
// be put inside a module and referenced by a impl so we also have to treat the
// item parent as transparent to module and for consistency we have to do the same
// for impl, otherwise the item-def and impl-def won't have the same parent.
let outermost_impl_parent = peel_parent_while(cx.tcx, parent, |tcx, did| {
tcx.def_kind(did) == DefKind::Const
&& tcx.opt_item_name(did) == Some(kw::Underscore)
tcx.def_kind(did) == DefKind::Mod
|| (tcx.def_kind(did) == DefKind::Const
&& tcx.opt_item_name(did) == Some(kw::Underscore))
});

// 2. We check if any of the paths reference a the `impl`-parent.
Expand Down
54 changes: 54 additions & 0 deletions tests/ui/lint/non-local-defs/convoluted-locals-132427.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// Regression tests for https://github.com/rust-lang/rust/issues/132427

//@ check-pass

// original
mod auth {
const _: () = {
pub enum ArbitraryContext {}

const _: () = {
impl ArbitraryContext {}
};
};
}

const _: () = {
mod auth {
const _: () = {
pub enum ArbitraryContext {}

const _: () = {
impl ArbitraryContext {}
};
};
}
};

mod a {
mod b {
const _: () = {
pub enum ArbitraryContext {}

const _: () = {
impl ArbitraryContext {}
};
};
}
}

mod foo {
const _: () = {
mod auth {
const _: () = {
pub enum ArbitraryContext {}

const _: () = {
impl ArbitraryContext {}
};
};
}
};
}

fn main() {}

0 comments on commit 6ae4697

Please sign in to comment.