Skip to content

Commit

Permalink
Auto merge of #53133 - Zoxc:gen-int, r=eddyb
Browse files Browse the repository at this point in the history
Record adjustments and original type for expressions in the generator interior

Fixes #50878 and #52398.

r? @eddyb
  • Loading branch information
bors committed Aug 15, 2018
2 parents 18a4c38 + 401af79 commit 5db71db
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/librustc_typeck/check/generator_interior.rs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,13 @@ impl<'a, 'gcx, 'tcx> Visitor<'tcx> for InteriorVisitor<'a, 'gcx, 'tcx> {

let scope = self.region_scope_tree.temporary_scope(expr.hir_id.local_id);

let ty = self.fcx.tables.borrow().expr_ty_adjusted(expr);
// Record the unadjusted type
let ty = self.fcx.tables.borrow().expr_ty(expr);
self.record(ty, scope, Some(expr), expr.span);

// Also include the adjusted types, since these can result in MIR locals
for adjustment in self.fcx.tables.borrow().expr_adjustments(expr) {
self.record(adjustment.target, scope, Some(expr), expr.span);
}
}
}
35 changes: 35 additions & 0 deletions src/test/run-pass/generator/issue-52398.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(generators)]

use std::cell::RefCell;

struct A;

impl A {
fn test(&self, a: ()) {}
}

fn main() {
// Test that the MIR local with type &A created for the auto-borrow adjustment
// is caught by typeck
move || {
A.test(yield);
};

// Test that the std::cell::Ref temporary returned from the `borrow` call
// is caught by typeck
let y = RefCell::new(true);
static move || {
yield *y.borrow();
return "Done";
};
}

0 comments on commit 5db71db

Please sign in to comment.