Skip to content

Commit

Permalink
Remove old FIXME that no longer applies
Browse files Browse the repository at this point in the history
it looks like Encodable was fallible at some point, but that was changed
which means that this FIXME is no longer applicable
  • Loading branch information
fee1-dead committed Feb 20, 2023
1 parent 96834f0 commit 255eb21
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions compiler/rustc_serialize/src/serialize.rs
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,6 @@ impl<D: Decoder, T: Decodable<D> + Copy> Decodable<D> for Cell<T> {
}
}

// FIXME: #15036
// Should use `try_borrow`, returning an
// `encoder.error("attempting to Encode borrowed RefCell")`
// from `encode` when `try_borrow` returns `None`.

impl<S: Encoder, T: Encodable<S>> Encodable<S> for RefCell<T> {
fn encode(&self, s: &mut S) {
self.borrow().encode(s);
Expand Down

0 comments on commit 255eb21

Please sign in to comment.