Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint example for collapsible_str_replace #9817

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Update lint example for collapsible_str_replace #9817

merged 1 commit into from
Nov 8, 2022

Conversation

mgrachev
Copy link
Contributor

@mgrachev mgrachev commented Nov 8, 2022

To fix this warning:

warning: the borrowed expression implements the required traits
  --> src/fixes/quote_character.rs:16:43
   |
16 |         let hello = "hesuo worpd".replace(&['s', 'u', 'p'], "l");
   |                                           ^^^^^^^^^^^^^^^^ help: change this to: `['s', 'u', 'p']`
   |
   = note: `#[warn(clippy::needless_borrow)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 8, 2022
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2022

📌 Commit 7001085 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 8, 2022

⌛ Testing commit 7001085 with merge c4fbe54...

@bors
Copy link
Contributor

bors commented Nov 8, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing c4fbe54 to master...

@bors bors merged commit c4fbe54 into rust-lang:master Nov 8, 2022
@mgrachev mgrachev deleted the patch-1 branch November 9, 2022 07:36
linyihai pushed a commit to linyihai/rust-clippy that referenced this pull request Oct 23, 2023
linyihai pushed a commit to linyihai/rust-clippy that referenced this pull request Oct 23, 2023
Auto merge of rust-lang#9817 - mgrachev:patch-1, r=Manishearth

Created-by: chenshuo 00511327
Author-id: 1557
MR-id: 423172
Commit-by: bors;Ryan Scheidter;Grachev Mikhail;Jason Newcomb;koka;Alex Macleod;Steven Casper;bebecue;Trevor Arjeski;Samuel Moelius;Lukas Markeffsky;xFrednet;kraktus;Andre Bogus;alexey semenyuk;Alex ✨ Cosmic Princess ✨;Gary Guo;dswijj;Rageking8;Elliot Bobrow;Alex;est31;oxalica;JT;Doru-Florin Blanzeanu;Andreu Botella;royrustdev;Philipp Krones;TennyZhuang;alex-semenyuk;Marijn Schouten;Michael Goulet;Steven Nguyen;Cody;Guillaume Gomez;Dylan DPC;Yuki Okushi;Maybe Waffle;Matthias Krüger;Urgau;Ralf Jung;Cameron Steffen;ouz-a;Nahua Kang
Merged-by: wangqilin 00349210
E2E-issues: 
Description:
合并社区提交:
从 a6444a6
到c4fbe54ac3916b42bb3469075abfef05803e3372
共203个提交记录

See merge request innersource/rust/toolset/rust-clippy!2
linyihai pushed a commit to linyihai/rust-clippy that referenced this pull request Oct 23, 2023
revert merge request: Auto merge of rust-lang#9817 - mgrachev:patch-1, r=Manishearth

43a6d0b

This revert merge request !2
linyihai pushed a commit to linyihai/rust-clippy that referenced this pull request Oct 23, 2023
…rce/rust/toolset/rust-clippy into master

* 'master' of https://szv-open.codehub.huawei.com/innersource/rust/toolset/rust-clippy:
  [build2.0] Create or modify the build.yml file.
  [build2.0] Create or modify the build.yml file.
  add by cloudInit.
  add by cloudInit.
  remove .cloudbuild
  remove .cloudbuild
  [build2.0] Create or modify the build.yml file.
  [build2.0] Create or modify the build.yml file.
  add by cloudInit.
  add by cloudInit.
  add cloudbuild config
  Fixed Typo
  Auto merge of rust-lang#9817 - mgrachev:patch-1, r=Manishearth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants