Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for Rust 1.65 #9761

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Changelog for Rust 1.65 #9761

merged 2 commits into from
Nov 3, 2022

Conversation

xFrednet
Copy link
Member

Roses are red,
violets are blue,
another 6 weeks,
another changelog, yahoo!

This did not rhyme,
luckily, not a crime.
I want to say something smart,
but I am out of time.


Note for the reviewer. This PR is written, as if Rust was already released on 2022-11-03. Please review the changes and approve if you agree, but only merge it after the release. :)


changelog: none

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 31, 2022
CHANGELOG.md Outdated
[#9373](https://github.com/rust-lang/rust-clippy/pull/9373)
* [`partialeq_to_none`]
[#9288](https://github.com/rust-lang/rust-clippy/pull/9288)
* [`positional_named_format_parameters`] ????
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [`positional_named_format_parameters`] ????
* [`positional_named_format_parameters`]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I was unsure about this one, as it was added to Clippy in #9040, but it seems like it was moved to rustc afterwards.

@dswij Do you know what the status of this lint is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was removed in #8518. It was originally an extension of the rustc lint, but was removed because the corresponding rustc lint now covers this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I'll remove it from the changelog. Thank you!

CHANGELOG.md Outdated
Comment on lines 74 to 75
* Renamed `blacklisted_name` to [`disallowed_names`]
[#8974](https://github.com/rust-lang/rust-clippy/pull/8974)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look like that it should be moved to Moves and Deprecations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just confused the sections :)

@xFrednet
Copy link
Member Author

xFrednet commented Nov 3, 2022

I'm merging this since Rust 1.65 has just been released. @giraffate if you have any new suggestions, you can add them here, and I'll then create a follow-up PR. I hope it's okay, that I set you as r= 🙃

@bors r=giraffate,xFrednet

@bors
Copy link
Contributor

bors commented Nov 3, 2022

📌 Commit 30e662d has been approved by giraffate,xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 3, 2022

⌛ Testing commit 30e662d with merge 6b4e7dd...

@bors
Copy link
Contributor

bors commented Nov 3, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate,xFrednet
Pushing 6b4e7dd to master...

@bors bors merged commit 6b4e7dd into rust-lang:master Nov 3, 2022
@xFrednet xFrednet deleted the changelog-1-65 branch November 3, 2022 15:03
@giraffate
Copy link
Contributor

@xFrednet Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants