Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle unescape warnings #9406

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Sep 1, 2022

fixes #9405

changelog: Fix ICE when format literals raise compiler warnings

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 1, 2022
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, but CI is failing

@Jarcho
Copy link
Contributor Author

Jarcho commented Sep 1, 2022

@bors r=Manishearth

@bors
Copy link
Contributor

bors commented Sep 1, 2022

📌 Commit d4a0785 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 1, 2022

⌛ Testing commit d4a0785 with merge 291f75e...

@bors
Copy link
Contributor

bors commented Sep 1, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 291f75e to master...

@bors bors merged commit 291f75e into rust-lang:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE checking cargo-xbuild-0.6.6
4 participants