Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend unnecessary_lazy_eval to cover bool::then -> bool::then_some #9099

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

joshtriplett
Copy link
Member

fixes #9097

changelog: Extend unnecessary_lazy_eval to convert bool::then to bool::then_some

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 2, 2022
@joshtriplett
Copy link
Member Author

This is WIP because I haven't managed to get the change to actually fire on the test case; I would appreciate advice on what I'm missing.

@ghost
Copy link

ghost commented Jul 5, 2022

This should probably have a MSRV check for 1.62.

@joshtriplett joshtriplett force-pushed the unnecessary-lazy-eval-then-some branch from 12eb1d3 to 9059bb2 Compare July 6, 2022 08:08
@joshtriplett joshtriplett marked this pull request as ready for review July 6, 2022 08:08
@flip1995
Copy link
Member

flip1995 commented Jul 6, 2022

cargo dev fmt and this should be good to go.

@joshtriplett joshtriplett force-pushed the unnecessary-lazy-eval-then-some branch from 9059bb2 to b7230d4 Compare July 6, 2022 09:04
@joshtriplett
Copy link
Member Author

@flip1995 Done.

@flip1995
Copy link
Member

flip1995 commented Jul 6, 2022

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 6, 2022

📌 Commit b7230d4 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jul 6, 2022

⌛ Testing commit b7230d4 with merge f93d418...

@bors
Copy link
Contributor

bors commented Jul 6, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing f93d418 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bool::then with trivial body should use bool::then_some
6 participants