Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try reading rust-version from Cargo.toml #8774

Merged
merged 4 commits into from
Jun 28, 2022
Merged

try reading rust-version from Cargo.toml #8774

merged 4 commits into from
Jun 28, 2022

Commits on Jun 28, 2022

  1. try reading rust-version from Cargo.toml 

    Cargo.toml can contain a field `rust-version`, that acts like a MSRV of
clippy.toml file: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
This will try to read that field and use it, if the clippy.toml config
has no `msrv` entry
    @hellow554
    hellow554 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    81737bf View commit details
    Browse the repository at this point in the history

  2. update README.md to reflect rust-version in cargo.toml

    @hellow554
    hellow554 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    83511d1 View commit details
    Browse the repository at this point in the history

  3. parse Cargo.toml file in ui-cargo tests 

    compiletest_rs is not meant to test full cargo projects, but instead
only files.
So we need to parse the `Cargo.toml` file ourself and set the
corresponding environment variable. In this case we just set
`CARGO_PKG_RUST_VERSION`, nothing more. But, of course, this can be
extended.
    @hellow554
    hellow554 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    6384765 View commit details
    Browse the repository at this point in the history

  4. add uitests for cargo rust-version field

    @hellow554
    hellow554 committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    f0a1cd5 View commit details
    Browse the repository at this point in the history