Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redundant_closure fixes #8685

Merged
merged 3 commits into from
Jul 30, 2023
Merged

redundant_closure fixes #8685

merged 3 commits into from
Jul 30, 2023

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 11, 2022

fixes #8548

A good chunk of the code is fixing false negatives. The old code banned any non late-bound regions from appearing in the callee's signature. The new version checks when the late-bound region is actually required.

changelog: Better track when a early-bound region appears when a late-bound region is required in redundant_closure.
changelog: Don't lint redundant_closure when the closure gives explicit types.

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 11, 2022
@Jarcho Jarcho force-pushed the redundant_closure_fixes branch from e27f838 to 41be5d3 Compare April 11, 2022 17:23
@Manishearth Manishearth requested a review from flip1995 April 11, 2022 20:15
@Manishearth Manishearth removed their assignment Apr 11, 2022
@Manishearth
Copy link
Member

may not have time to get to this quickly, bouncing it over, feel free to bounce to someone else

@bors
Copy link
Contributor

bors commented Apr 14, 2022

☔ The latest upstream changes (presumably #8676) made this pull request unmergeable. Please resolve the merge conflicts.

@m-ou-se
Copy link
Member

m-ou-se commented Aug 9, 2022

r? @flip1995

@flip1995
Copy link
Member

flip1995 commented Aug 10, 2022 •
edited
Loading

I will be on $day_job vacation starting Saturday and then finally have time to go through my whole review queue over the weekend and next week 🎉

@Jarcho Jarcho force-pushed the redundant_closure_fixes branch from 41be5d3 to 0c7a202 Compare August 17, 2022 01:18
@bors
Copy link
Contributor

bors commented Sep 8, 2022

☔ The latest upstream changes (presumably #9447) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the redundant_closure_fixes branch from 0c7a202 to 73ef072 Compare February 25, 2023 02:29
@Jarcho
Copy link
Contributor Author

Jarcho commented Feb 25, 2023

ping @flip1995. Just a reminder this still exists.

@Jarcho Jarcho force-pushed the redundant_closure_fixes branch 2 times, most recently from 7763efd to 686ae9b Compare February 25, 2023 04:19
@bors
Copy link
Contributor

bors commented Feb 26, 2023

☔ The latest upstream changes (presumably #10401) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the redundant_closure_fixes branch from 686ae9b to d75101d Compare February 26, 2023 03:41
@bors
Copy link
Contributor

bors commented Mar 10, 2023

☔ The latest upstream changes (presumably #10473) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the redundant_closure_fixes branch from d75101d to ca658d5 Compare March 10, 2023 16:37
@bors
Copy link
Contributor

bors commented Mar 21, 2023

☔ The latest upstream changes (presumably #10520) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the redundant_closure_fixes branch 2 times, most recently from 0395535 to 6a0af57 Compare June 9, 2023 22:59
@Jarcho
Copy link
Contributor Author

Jarcho commented Jun 9, 2023

Since @flip1995 doesn't really have time.

r? @llogiq

@bors
Copy link
Contributor

bors commented Jun 30, 2023

☔ The latest upstream changes (presumably #11048) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho mentioned this pull request Jul 16, 2023
Open
@llogiq
Copy link
Contributor

llogiq commented Jul 23, 2023

Took me a while to read through, but looks good to me. r=me with the conflicts fixed.

@bors delegate

@llogiq
Copy link
Contributor

llogiq commented Jul 23, 2023

Oops, missed a plus sign.

@bors delegate+

@bors
Copy link
Contributor

bors commented Jul 23, 2023

✌️ @Jarcho, you can now approve this pull request!

If @llogiq told you to "r=me" after making some further change, please make that change, then do @bors r=@llogiq

@Jarcho
Add debug assertions to implements_trait
71cc39e 
Improve debug assertions for `make_projection`
@Jarcho Jarcho force-pushed the redundant_closure_fixes branch from 6a0af57 to d881143 Compare July 30, 2023 05:11
Jarcho added 2 commits July 30, 2023 01:19
@Jarcho
Rework redundant_closure
4d80a2e 
* Better track when a early-bound region appears when a late-bound region is required
* Don't lint when the closure gives explicit types.
@Jarcho
Don't lint redundant closure for any function call inserted by the co…
7423c27 
…mpiler.
@Jarcho Jarcho force-pushed the redundant_closure_fixes branch from d881143 to 7423c27 Compare July 30, 2023 05:19
@Jarcho
Copy link
Contributor Author

Jarcho commented Jul 30, 2023

The terrible diff probably didn't help much with that.

@bors r=@llogiq

@bors
Copy link
Contributor

bors commented Jul 30, 2023

📌 Commit 7423c27 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 30, 2023

⌛ Testing commit 7423c27 with merge 4c2f460...

@bors
Copy link
Contributor

bors commented Jul 30, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 4c2f460 to master...

@bors bors merged commit 4c2f460 into rust-lang:master Jul 30, 2023
@y21 y21 mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 Awaiting requested review from flip1995

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant closue lint can lose type annotation
7 participants
@Jarcho @rust-highfive @Manishearth @bors @m-ou-se @flip1995 @llogiq