Add unnecessary_find_map lint
#8489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
Mar 1, 2022
tests/ui/unnecessary_filter_map.rs
Outdated
| @@ -2,26 +2,43 @@ | |||
|
|
|||
| fn main() { | |||
| let _ = (0..4).filter_map(|x| if x > 1 { Some(x) } else { None }); | |||
| let _ = (0..4).find_map(|x| if x > 1 { Some(x) } else { None }); | |||
There was a problem hiding this comment.
Could you factor those tests out into their own ui test file?
smoelius
force-pushed
the
unnecessary-find-map
branch
from
c38fe51 to
6ff12f8
Compare
smoelius
force-pushed
the
unnecessary-find-map
branch
from
6ff12f8 to
2a588d8
Compare
|
Thank you! @bors r+ |
|
📌 Commit 2a588d8 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
unnecessary_find_maplint. It is essentially just a minor enhancement ofunnecessary_filter_map.Closes #8467
changelog: New lint
unnecessary_find_map