-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit_write
suggestions for write!
s with format args
#8365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsteffen
reviewed
Jan 28, 2022
d253263
to
8f2df87
Compare
camsteffen
reviewed
Jan 28, 2022
8f2df87
to
28b192c
Compare
camsteffen
reviewed
Feb 4, 2022
28b192c
to
144b4a5
Compare
@rustbot ready Forgot to do that 👀 |
Thanks! @bors r+ |
📌 Commit 144b4a5 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Add [
explicit_write
] suggestions forwrite!
s with format argsFixes #4542
Now suggests:
r? @camsteffen (again, sorry 😛) for the
FormatArgsExpn
changeBefore this change
inputs_span
returned a span pointing to just1
inAnd the
source_callsite
of that span didn't include the format string, it was justone!()