Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual_memcpy fix #8226

Merged
merged 3 commits into from
Jan 12, 2022
Merged

manual_memcpy fix #8226

merged 3 commits into from
Jan 12, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jan 5, 2022

fixes #8160

Ideally this would work with VecDeque, but the current interface is unsuitable for it. At a minimum something like range_as_slices would be needed.

changelog: Don't lint manual_memcpy on VecDeque
changelog: Suggest copy_from_slice for manual_memcpy when applicable

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 5, 2022
@flip1995
Copy link
Member

Can you add a test case for the VecDeque case, please? Otherwise this LGTM.

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 12, 2022
@flip1995
Copy link
Member

Perfect, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 12, 2022

📌 Commit 062db10 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jan 12, 2022

⌛ Testing commit 062db10 with merge 60e68d6...

@bors
Copy link
Contributor

bors commented Jan 12, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 60e68d6 to master...

@bors bors merged commit 60e68d6 into rust-lang:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad suggestion to clone_from_slice from VecDeque
4 participants