Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx FP in missing_safety_doc lint #7849

Merged
merged 1 commit into from
Oct 20, 2021
Merged

FIx FP in missing_safety_doc lint #7849

merged 1 commit into from
Oct 20, 2021

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Oct 20, 2021

Fix FP where lint souldn't fire if any parent has #[doc(hidden)] attribute

fixes: #7347

changelog: [missing_safety_doc] Fix FP if any parent has #[doc(hidden)] attribute

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 20, 2021
@ThibsG
Copy link
Contributor Author

ThibsG commented Oct 20, 2021

r? @llogiq

@rust-highfive rust-highfive assigned llogiq and unassigned Manishearth Oct 20, 2021
@llogiq
Copy link
Contributor

llogiq commented Oct 20, 2021

Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2021

📌 Commit 3630afb has been approved by llogiq

@bors
Copy link
Contributor

bors commented Oct 20, 2021

⌛ Testing commit 3630afb with merge f11905a...

@bors
Copy link
Contributor

bors commented Oct 20, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing f11905a to master...

@bors bors merged commit f11905a into rust-lang:master Oct 20, 2021
@ThibsG ThibsG deleted the SafetyDoc branch October 20, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing_safety_doc should be surpressed by parent #[doc(hidden)]
5 participants