fix while_let_on_iterator suggestion in a closure
#7262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @phansch (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
reviewed
May 27, 2021
xFrednet
approved these changes
Jun 6, 2021
|
📌 Commit 7db0e4f has been approved by |
bors
added a commit
that referenced
this pull request
Jun 8, 2021
fix `while_let_on_iterator` suggestion in a closure fixes: #7249 A future improvement would be to check if the closure is being used as `FnOnce`, in which case the original suggestion would be correct. changelog: Suggest `&mut iter` inside a closure for `while_let_on_iterator`
|
@bors r=xFrednet,flip1995 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 7db0e4f has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7249
A future improvement would be to check if the closure is being used as
FnOnce, in which case the original suggestion would be correct.changelog: Suggest
&mut iterinside a closure forwhile_let_on_iterator