lintcheck, do some refactoring and add more sources #6813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @phansch (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #6787) made this pull request unmergeable. Please resolve the merge conflicts. |
…olds the job limit and paths to the sources and log files
…o the source files of a warning into the lintcheck log This is more convenient when reviewing new lint warnings that popped up in the logs
fix a couple of issues when checking if lintcheck needed rerun after clippy binary changed. I was apparently still comparing the times wrongly, but it should be fixed™ now... I actually looked at the date of the sources.toml and not at the date of the log file! Also fix progress report counter not advancing in squential mode
…ectory from traget/lintcheck/crates to target/lintcheck/sources also update logfile with the dtolnay crates
matthiaskrgr
force-pushed
the
lintcheck_refactor
branch
from
6b3a309 to
25f9098
Compare
|
@bors r+ Thanks! |
|
📌 Commit 25f9098 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 1, 2021
lintcheck, do some refactoring and add more sources refactor: add a Config object don't run in parallel mode by default (it didn't make sense because cargo would lock the shared target dir anyway) show full paths (from repo root) to the source files in clippy warnings so we can just copy the path from the logfile fix more bugs add more crates by dtolnay and embark to the sources toml changelog: lintcheck: refactor some code and add more sources
|
💥 Test timed out |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Mar 1, 2021
lintcheck, do some refactoring and add more sources refactor: add a Config object don't run in parallel mode by default (it didn't make sense because cargo would lock the shared target dir anyway) show full paths (from repo root) to the source files in clippy warnings so we can just copy the path from the logfile fix more bugs add more crates by dtolnay and embark to the sources toml changelog: lintcheck: refactor some code and add more sources
|
Job did not start... |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: add a Config object
don't run in parallel mode by default (it didn't make sense because cargo would lock the shared target dir anyway)
show full paths (from repo root) to the source files in clippy warnings so we can just copy the path from the logfile
fix more bugs
add more crates by dtolnay and embark to the sources toml
changelog: lintcheck: refactor some code and add more sources