Added lint str_to_string

[PunitLodha]

Please write a short comment explaining your change (or "none" for internal only changes)
changelog: un-deprecate [str_to_string] and [string_to_string] and introduce them as restriction lints again.
Fixes #5610
Added new lint:- str_to_string
r? @flip1995

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[PunitLodha]

I have commented out some lines, you can check and let me know if i should remove those lines.
Two tests are failing,
failures:
[ui] ui/deprecated.rs
[ui] ui/deprecated_old.rs
Should i update these too?

Also running cargo dev update lints, adds store.register_removed to src/lib.rs for str_to_string and string_to_string. How can i fix this?

[ThibsG]

Only some NITs, thanks for working on this.
On a general note, do not hesitate to remove the lines instead of commenting them, I think it is more visual and easy to review removed lines 😄

Also, you can update ui/deprecated.rs and ui/deprecated_old.rs.

Also running cargo dev update lints, adds store.register_removed to src/lib.rs for str_to_string and string_to_string. How can i fix this?

That's weird, I'd say removing stuff from clippy_lints/src/lib.rs would do the trick, but maybe there is some mechanism for removed lints I am not aware. If I found something I'll let you know.

[flip1995]

impl LGTM overall. Some code cleanup left to do.

Also running cargo dev update lints, adds store.register_removed to src/lib.rs for str_to_string and string_to_string. How can i fix this?

That was, because you only commented out the deprecate_clippy_lint! macros, instead of removing them. cargo dev update_lints only searches files for strings and does not parse Rust code.

[flip1995]

Those to lints should be in the same module. There is already a strings module, so you can put these lints there.

And while you're there, you could combine all the LateLintPass implementations in the strings module into one. But please do this in an extra commit. (Or leave it for a later PR)

[PunitLodha]

Adding the two lints to the strings.rs file would do it? Also by combining all the LateLintPass implementations do you mean that there should be only one of it for all the lints in string.rs file?

[flip1995]

do you mean that there should be only one of it for all the lints in string.rs file?

Yes, exactly.

Adding the two lints to the strings.rs file would do it?

You also have to copy over the code in the LateLintPass impls, but you can reuse the LateLintPass impl in the other module.

[PunitLodha]

I think combining all the LateLintPass implementations could be done in a new PR

[bors]

☔ The latest upstream changes (presumably #6351) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[PunitLodha]

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[flip1995]

Some formulations. Remember to update the reference files after those changes.

Also, please squash your commits.

[PunitLodha]

Made the requested changes, and squashed to a single commit

[flip1995]

@bors r+

Thanks!

[bors]

📌 Commit 2345ef5 has been approved by flip1995

[bors]

⌛ Testing commit 2345ef5 with merge ae57785...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing ae57785 to master...