Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong use of snippet_with_applicability #5968

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

rail-rain
Copy link
Contributor

For the context, please see #5822 (comment) and #5822 (comment).


changelog: none

This includes a workaround of the issue rust-lang#5822,
the cause of this little mistake.
@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 26, 2020
@flip1995
Copy link
Member

@bors r+

Thanks, I also took a look at how to fix this, let's see if my plan works during the weekend.

@bors
Copy link
Contributor

bors commented Aug 26, 2020

📌 Commit edc05da has been approved by flip1995

@bors
Copy link
Contributor

bors commented Aug 26, 2020

⌛ Testing commit edc05da with merge e45c59e...

@bors
Copy link
Contributor

bors commented Aug 26, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing e45c59e to master...

@bors bors merged commit e45c59e into rust-lang:master Aug 26, 2020
@rail-rain rail-rain deleted the fix_use_snippet_with_applicability branch August 26, 2020 23:46
@jnaulty
Copy link

jnaulty commented Aug 27, 2020

/help

@ghost
Copy link

ghost commented Aug 28, 2020

Thanks, I also took a look at how to fix this, let's see if my plan works during the weekend.

Fixed something similar in #4164. It would probably work for #5822 as well. Assuming the functions show up as mutated variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants